feat: support terminal to open folder and file #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 59.01% 59.01% -0.01%
==========================================
Files 1200 1200
Lines 73916 73947 +31
Branches 15293 15303 +10
==========================================
+ Hits 43623 43639 +16
- Misses 27611 27623 +12
- Partials 2682 2685 +3
Continue to review full report at Codecov.
|
erha19
requested changes
Feb 24, 2022
packages/terminal-next/src/browser/links/validated-local-link-provider.ts
Show resolved
Hide resolved
|
@yantze 看一下，补充一下对应测试用例 |
新增的正则 winExcludedPathCharactersClause lineAndColumnClause 在 terminalValidatedLocalLinkProvider.test.ts 是有对这些路径进行测试校验的。 |
erha19
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
close #486
Changelog
support terminal to open folder and file