feat: migrate walk through snippets provider to file-scheme module #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erha19
previously approved these changes
Jul 14, 2022
eb7cc36
to
9ffc286
Compare
|
我比较建议这个可以先放到 main 分支，跟 2.21 版本发布 @Aaaaash |
可以，这个不着急 |
|
冲突需要处理一下 @Aaaaash |
Codecov ReportBase: 57.62% // Head: 57.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 57.62% 57.60% -0.02%
==========================================
Files 1285 1285
Lines 80175 80177 +2
Branches 16796 16797 +1
==========================================
- Hits 46198 46189 -9
- Misses 30907 30916 +9
- Partials 3070 3072 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
erha19
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
由于
walkThroughSnippets协议的文档在 output 以及 debug 模块都有用到，原有的实现将该 provider 注册放在 debug 模块不太合理，迁移到 file-scheme 模块与其他通用 scheme 注册放在一起Changelog
walkThroughSnippetsscheme 的注册逻辑到 file-scheme 模块