[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement comment timestamp #1595

Merged
merged 1 commit into from
Sep 13, 2022
Merged

feat: implement comment timestamp #1595

merged 1 commit into from
Sep 13, 2022

Conversation

hacke2
Copy link
Member
@hacke2 hacke2 commented Aug 29, 2022

Types

  • 🎉 New Features

Background or solution

resolve #1411

image

Changelog

implement comment timestamp

@hacke2
Copy link
Member Author
hacke2 commented Aug 29, 2022

测试插件写法

const commentController = vscode.comments.createCommentController('comment-sample', 'Comment API Sample');
  commentController.createCommentThread(vscode.window.activeTextEditor.document.uri, new vscode.Range(1, 1, 1, 1), [{
    author: {
      name: '蛋总'
    },
    body: '评论',
    mode: vscode.CommentMode.Preview,
    timestamp: new Date()
  },
  {
    author: {
      name: '蛋总'
    },
    body: '回复1',
    mode: vscode.CommentMode.Preview,
    timestamp: new Date()
  }, {
    author: {
      name: '蛋总'
    },
    body: '回复2',
    mode: vscode.CommentMode.Preview,
    timestamp: new Date()
}])

@codecov
Copy link
codecov bot commented Aug 29, 2022

Codecov Report

Base: 57.69% // Head: 57.66% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (c47118c) compared to base (236fd4c).
Patch has no changes to coverable lines.

❗ Current head c47118c differs from pull request most recent head 496f890. Consider uploading reports for the commit 496f890 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1595      +/-   ##
==========================================
- Coverage   57.69%   57.66%   -0.03%     
==========================================
  Files        1254     1253       -1     
  Lines       78139    78168      +29     
  Branches    16328    16331       +3     
==========================================
- Hits        45079    45077       -2     
- Misses      30091    30122      +31     
  Partials     2969     2969              
Flag Coverage Δ
jsdom 52.46% <0.00%> (-0.03%) ⬇️
node 15.83% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/terminal-next/src/browser/terminal.addon.ts 36.11% <0.00%> (-23.54%) ⬇️
.../src/browser/view/console/debug-console.service.ts 15.02% <0.00%> (-0.40%) ⬇️
...components/src/recycle-tree/prompt/PromptHandle.ts 89.54% <0.00%> (-0.14%) ⬇️
packages/components/src/utils/index.ts 100.00% <0.00%> (ø)
packages/terminal-next/src/browser/xterm.ts 82.89% <0.00%> (ø)
packages/extension/src/common/vscode/converter.ts 41.08% <0.00%> (ø)
packages/markdown/src/browser/markdown.service.ts 73.07% <0.00%> (ø)
...ckages/terminal-next/src/browser/terminal.color.ts 100.00% <0.00%> (ø)
...ckages/terminal-next/src/browser/terminal.theme.ts 0.00% <0.00%> (ø)
packages/components/src/utils/marked.ts
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 82ab63b into main Sep 13, 2022
@erha19 erha19 deleted the feat/comment-timestamp branch September 13, 2022 10:07
yantze pushed a commit that referenced this pull request Sep 19, 2022
bytemain pushed a commit that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Comment timestamp API
2 participants