[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): arrow up key doesn't trigger search #1774

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

bytemain
Copy link
Member
@bytemain bytemain commented Oct 11, 2022

Types

  • 🐛 Bug Fixes

Background or solution

this close: #1672

Changelog

auto search value when history triggered

@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
@codecov
Copy link
codecov bot commented Oct 12, 2022

Codecov Report

Base: 57.74% // Head: 57.74% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (63051da) compared to base (65d33e9).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
- Coverage   57.74%   57.74%   -0.01%     
==========================================
  Files        1280     1280              
  Lines       79571    79575       +4     
  Branches    16659    16659              
==========================================
+ Hits        45950    45951       +1     
- Misses      30592    30595       +3     
  Partials     3029     3029              
Flag Coverage Δ
jsdom 52.58% <25.00%> (-0.02%) ⬇️
node 15.89% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/search/src/common/content-search.ts 67.90% <ø> (ø)
packages/search/src/node/content-search.service.ts 77.46% <66.66%> (-0.24%) ⬇️
packages/search/src/browser/search-history.ts 86.15% <100.00%> (+0.21%) ⬆️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
packages/utils/src/strings.ts 33.96% <0.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit a677a03 into main Oct 14, 2022
@erha19 erha19 deleted the fix/search-trigger branch October 14, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 2.19.11 搜索面板中 在搜索内容框里按方向键没有触发重新搜索
2 participants