[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 编辑器面包屑导航支持已注册的文件协议 #1804

Merged
merged 2 commits into from
Oct 20, 2022
Merged

feat: 编辑器面包屑导航支持已注册的文件协议 #1804

merged 2 commits into from
Oct 20, 2022

Conversation

Aaaaash
Copy link
Member
@Aaaaash Aaaaash commented Oct 19, 2022

Types

  • 🎉 New Features

Background or solution

Changelog

  • 编辑器面包屑导航支持已注册的文件协议

@erha19
Copy link
Member
erha19 commented Oct 19, 2022

这个也整到 main 吧，2.20 东西太多了，非阻塞性的功能不上了，发到 2.21

@codecov
Copy link
codecov bot commented Oct 19, 2022

Codecov Report

Base: 57.59% // Head: 57.58% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ddccc0c) compared to base (6f39394).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##            v2.20    #1804      +/-   ##
==========================================
- Coverage   57.59%   57.58%   -0.01%     
==========================================
  Files        1257     1257              
  Lines       78469    78526      +57     
  Branches    16438    16452      +14     
==========================================
+ Hits        45191    45220      +29     
- Misses      30276    30301      +25     
- Partials     3002     3005       +3
Flag Coverage Δ
jsdom 52.38% <100.00%> (-0.01%) ⬇️
node 15.84% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/editor/src/browser/breadcrumb/default.ts 52.50% <100.00%> (ø)
...kages/workspace/src/common/workspace.definition.ts 94.33% <100.00%> (ø)
packages/main-layout/src/browser/tabbar-handler.ts 70.45% <0.00%> (-13.33%) ⬇️
...ion/src/browser/vscode/api/main.thread.treeview.ts 47.60% <0.00%> (-1.18%) ⬇️
...-layout/src/browser/accordion/accordion.service.ts 64.77% <0.00%> (-0.83%) ⬇️
packages/terminal-next/src/browser/xterm.ts 82.35% <0.00%> (-0.55%) ⬇️
packages/extension/src/common/vscode/ext-types.ts 50.36% <0.00%> (-0.04%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 60.31% <0.00%> (-0.02%) ⬇️
packages/editor/src/common/editor.ts 100.00% <0.00%> (ø)
packages/core-browser/src/utils/index.ts 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 changed the title 编辑器面包屑导航支持已注册的文件协议 feat: 编辑器面包屑导航支持已注册的文件协议 Oct 20, 2022
@erha19 erha19 merged commit f4c0007 into v2.20 Oct 20, 2022
@erha19 erha19 deleted the fix/editor-breadcrumb-support-any-scheme branch October 20, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erha19 erha19 erha19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aaaaash @erha19