[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unified menubar background color #1812

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix: unified menubar background color #1812

merged 1 commit into from
Oct 20, 2022

Conversation

bytemain
Copy link
Member

Types

  • 💄 Style Changes

Background or solution

现在我们对 menubar 设置颜色的 css 变量是错的:
CleanShot 2022-10-19 at 19 31 41@2x

而且造成了错误的样式生效,
CleanShot 2022-10-19 at 19 33 08@2x

应该使用 --kt-menubar-background

CleanShot 2022-10-19 at 19 32 24@2x

Changelog

unified menubar background color

@codecov
Copy link
codecov bot commented Oct 19, 2022

Codecov Report

Base: 57.61% // Head: 57.60% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (de5f69f) compared to base (8981be8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
- Coverage   57.61%   57.60%   -0.01%     
==========================================
  Files        1285     1285              
  Lines       80175    80175              
  Branches    16796    16796              
==========================================
- Hits        46193    46186       -7     
- Misses      30910    30917       +7     
  Partials     3072     3072              
Flag Coverage Δ
jsdom 52.35% <ø> (-0.01%) ⬇️
node 15.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-common/src/node/port.ts 44.77% <0.00%> (-2.99%) ⬇️
packages/utils/src/buffer.ts 30.81% <0.00%> (-2.33%) ⬇️
packages/utils/src/strings.ts 39.26% <0.00%> (-0.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit adcc477 into main Oct 20, 2022
@erha19 erha19 deleted the fix/menubar-color branch October 20, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants