[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get correct unsaved files number #1827

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

erha19
Copy link
Member
@erha19 erha19 commented Oct 24, 2022

Types

  • 🐛 Bug Fixes

Background or solution

close #1821.

Changelog

get correct unsaved files number

@erha19 erha19 requested a review from Ricbet October 24, 2022 09:48
@erha19 erha19 added the 🐞 bug Something isn't working label Oct 24, 2022
@codecov
Copy link
codecov bot commented Oct 24, 2022

Codecov Report

Base: 57.60% // Head: 57.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f899de6) compared to base (dd88924).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
- Coverage   57.60%   57.59%   -0.02%     
==========================================
  Files        1285     1285              
  Lines       80211    80215       +4     
  Branches    16806    16808       +2     
==========================================
- Hits        46203    46197       -6     
- Misses      30933    30941       +8     
- Partials     3075     3077       +2     
Flag Coverage Δ
jsdom 52.33% <0.00%> (-0.02%) ⬇️
node 15.90% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/editor/src/browser/workbench-editor.service.ts 60.09% <0.00%> (-0.23%) ⬇️
packages/utils/src/buffer.ts 30.81% <0.00%> (-4.07%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
packages/core-common/src/node/port.ts 47.76% <0.00%> (+2.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 3132e58 into main Oct 25, 2022
@erha19 erha19 deleted the fix/opened-editor/get-unsaved-files-number branch October 25, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OpenedEditor count unsave files duplicated
2 participants