[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the preference markdown display with placeholder #1854

Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix: the preference markdown display with placeholder #1854

merged 2 commits into from
Oct 26, 2022

Conversation

yantze
Copy link
Member
@yantze yantze commented Oct 26, 2022 •
edited
Loading

Types

  • 🐛 Bug Fixes

Background or solution

  • 修复部分设置项需要转为 markdown 展示，如果是用 localize 会提前让英文见面也展示为中文
  • 修正文字错误

image

image

Changelog

fix: 修复设置项不能展示 markdown

@github-actions github-actions bot added the 🐞 bug Something isn't working label Oct 26, 2022
yantze added a commit that referenced this pull request Oct 26, 2022
@yantze
chore: use markdown with placeholder(#1854)
614025d
@codecov
Copy link
codecov bot commented Oct 26, 2022

Codecov Report

Base: 57.57% // Head: 57.58% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (48e6510) compared to base (69ba8b8).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   57.57%   57.58%           
=======================================
  Files        1285     1285           
  Lines       80236    80236           
  Branches    16811    16811           
=======================================
+ Hits        46196    46200    +4     
+ Misses      30961    30958    -3     
+ Partials     3079     3078    -1
Flag Coverage Δ
jsdom 52.33% <ø> (+<0.01%) ⬆️
node 15.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/core-preferences.ts 92.30% <ø> (ø)
packages/editor/src/browser/preference/schema.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/search/src/browser/search-preferences.ts 66.66% <ø> (ø)
packages/task/src/common/index.ts 100.00% <ø> (ø)
...kages/theme/src/browser/workbench.theme.service.ts 71.75% <0.00%> (+0.57%) ⬆️
...erences/src/browser/preference-settings.service.ts 75.62% <0.00%> (+0.62%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 09f5813 into main Oct 26, 2022
@erha19 erha19 deleted the fix/correct-preference-text branch October 26, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erha19 erha19 erha19 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yantze @erha19