[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submenus error #1867

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix: submenus error #1867

merged 1 commit into from
Oct 28, 2022

Conversation

Aaaaash
Copy link
Member
@Aaaaash Aaaaash commented Oct 28, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

  • 修复 submenu 意外抛出的错误

@github-actions github-actions bot added the 🐞 bug Something isn't working label Oct 28, 2022
@codecov
Copy link
codecov bot commented Oct 28, 2022

Codecov Report

Base: 57.63% // Head: 57.63% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (12da923) compared to base (75511a4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
- Coverage   57.63%   57.63%   -0.01%     
==========================================
  Files        1284     1284              
  Lines       80389    80389              
  Branches    16823    16824       +1     
==========================================
- Hits        46333    46329       -4     
- Misses      30975    30978       +3     
- Partials     3081     3082       +1     
Flag Coverage Δ
jsdom 52.39% <100.00%> (-0.01%) ⬇️
node 15.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/extension/src/browser/extension.service.ts 47.76% <100.00%> (ø)
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.38% <0.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 47f0f8a into main Oct 28, 2022
@erha19 erha19 deleted the fix/submenu-errors branch October 28, 2022 08:26
erha19 pushed a commit that referenced this pull request Oct 28, 2022
erha19 added a commit that referenced this pull request Oct 31, 2022
* test: add opened editor e2e test

* chore: update split editor timeout

* chore: trigger editor title menu by id

* feat: 优化部分启动逻辑 (#1772)

* feat: optimize initialize performance

* chore: deps

* refactor: (wip) add lifecycle service

* refactor: (wip)

* refactor: 重构 vscode contributes 运行机制

* fix: test case

* chore: unused code

* refactor: register language logic

* chore: test case

* chore: test case

* chore: revert config

* fix: theme contribution

* chore: update comments

* chore: fix build error

Co-authored-by: Dan <danwu.wdw@alibaba-inc.com>

* chore: update labeler.yml

* fix: some event should not be dispose while switch session (#1866)

* refactor: parallel open resource (#1873)

* chore: improve append view performance (#1871)

* chore: improve append view performance

* chore: improve append view performance

* fix: submenus error (#1867)

* chore: update view quick open prefix (#1869)

* test: implement run debug e2e test case (#1787)

* test: implement debug breakpoint editor glyph margin test case

* test: code

* test: implement run debug test case

* fix: ci

* fix: ci

* fix: ci

* chore: fix ci

* test: implement debug breakpoint editor glyph margin test case

* fix: improve debug code

Co-authored-by: kuiwu <danwu.wdw@alibaba-inc.com>

* chore: change filetree context menu order (#1868)

* chore: fix new file test

Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
Co-authored-by: John <qingyi.xjh@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants