[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 将部分耗时较高的操作延迟运行 #1872

Merged
merged 2 commits into from
Oct 31, 2022
Merged

refactor: 将部分耗时较高的操作延迟运行 #1872

merged 2 commits into from
Oct 31, 2022

Conversation

Aaaaash
Copy link
Member
@Aaaaash Aaaaash commented Oct 28, 2022

Types

  • 🚀 Performance Improvements

Background or solution

Changelog

  • refactor: 将部分耗时较高的操作延迟运行

@github-actions github-actions bot added the ⚙️ refactor Refactor code label Oct 28, 2022
@erha19
Copy link
Member
erha19 commented Oct 31, 2022

image

@Aaaaash 处理一下

@life2015
Copy link
Member

LGTM

@codecov
Copy link
codecov bot commented Oct 31, 2022

Codecov Report

Base: 57.63% // Head: 57.66% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (53bd367) compared to base (75511a4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
+ Coverage   57.63%   57.66%   +0.02%     
==========================================
  Files        1284     1284              
  Lines       80389    80403      +14     
  Branches    16823    16826       +3     
==========================================
+ Hits        46333    46364      +31     
+ Misses      30975    30961      -14     
+ Partials     3081     3078       -3
Flag Coverage Δ
jsdom 52.41% <100.00%> (+0.02%) ⬆️
node 15.89% <14.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/core-browser/src/services/storage-service.ts 76.92% <100.00%> (+0.29%) ⬆️
packages/keymaps/src/browser/keymaps.service.ts 60.42% <100.00%> (-0.17%) ⬇️
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
packages/components/src/recycle-tree/tree/Tree.ts 90.47% <0.00%> (-0.83%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.38% <0.00%> (-0.58%) ⬇️
...ackages/debug/src/browser/debug-session-manager.ts 66.44% <0.00%> (-0.55%) ⬇️
...-layout/src/browser/accordion/accordion.service.ts 64.70% <0.00%> (-0.08%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 60.07% <0.00%> (-0.06%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit dd06f9b into main Oct 31, 2022
@erha19 erha19 deleted the refactor/run-some-task-when-idle branch October 31, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erha19 erha19 erha19 approved these changes

Assignees
No one assigned
Labels
⚙️ refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aaaaash @erha19 @life2015