[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: dialog message title center #2169

Merged
merged 1 commit into from
Jan 5, 2023
Merged

style: dialog message title center #2169

merged 1 commit into from
Jan 5, 2023

Conversation

Ricbet
Copy link
Member
@Ricbet Ricbet commented Jan 5, 2023

Types

  • 💄 Style Changes

Background or solution

Changelog

修复 dialog 弹窗标题不居中的问题

@Ricbet Ricbet requested review from hacke2 and erha19 January 5, 2023 11:00
hacke2
hacke2 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member
@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Ricbet Ricbet self-assigned this Jan 5, 2023
@codecov
Copy link
codecov bot commented Jan 5, 2023

Codecov Report

Base: 57.49% // Head: 57.50% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8f7ab2d) compared to base (9988799).
Patch coverage: 34.48% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##            v2.21    #2169   +/-   ##
=======================================
  Coverage   57.49%   57.50%           
=======================================
  Files        1286     1286           
  Lines       80542    80509   -33     
  Branches    16853    16851    -2     
=======================================
- Hits        46307    46293   -14     
+ Misses      31119    31105   -14     
+ Partials     3116     3111    -5
Flag Coverage Δ
jsdom 52.26% <34.48%> (+0.01%) ⬆️
node 15.88% <3.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/components/src/recycle-tree/tree/Tree.ts 88.88% <ø> (-1.59%) ⬇️
...re-browser/src/keyboard/keyboard-layout-service.ts 90.52% <ø> (ø)
packages/core-browser/src/keyboard/keys.ts 79.55% <0.00%> (ø)
...wser/view/breakpoints/debug-breakpoints.service.ts 79.59% <ø> (ø)
...sion/src/browser/sumi/contributes/browser-views.ts 67.27% <0.00%> (ø)
...on/src/browser/vscode/contributes/configuration.ts 67.74% <ø> (ø)
...tension/src/hosted/api/vscode/ext.host.treeview.ts 57.72% <ø> (+0.27%) ⬆️
...aco/src/browser/monaco-snippet-suggest-provider.ts 28.00% <0.00%> (ø)
...s/monaco/src/browser/monaco.resolved-keybinding.ts 12.06% <0.00%> (ø)
...ext/src/browser/contribution/terminal.lifecycle.ts 0.00% <0.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet Ricbet merged commit 920c696 into v2.21 Jan 5, 2023
@Ricbet Ricbet deleted the style/dialog-message-title branch January 5, 2023 11:43
@erha19
Copy link
Member
erha19 commented Jan 10, 2023 •
edited
Loading

这里的修改会导致文件报错弹窗样式异常
image

@erha19 erha19 mentioned this pull request Jan 10, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacke2 hacke2 hacke2 approved these changes

@erha19 erha19 Awaiting requested review from erha19

Assignees

@Ricbet Ricbet

Labels
💄 style change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ricbet @erha19 @hacke2