[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resizeObserver unobserve error #2183

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix: resizeObserver unobserve error #2183

merged 1 commit into from
Jan 11, 2023

Conversation

AhkunTa
Copy link
Member
@AhkunTa AhkunTa commented Jan 10, 2023 •
edited
Loading

Types

  • 🐛 Bug Fixes

Background or solution

截屏2023-01-10 15 51 45

Changelog

@github-actions github-actions bot added the 🐞 bug Something isn't working label Jan 10, 2023
@AhkunTa
Copy link
Member Author
AhkunTa commented Jan 10, 2023

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.21.13-next-1673339651.0 publish successful! You can install prerelease version via npm install package@2.21.13-next-1673339651.0 @AhkunTa

2.21.13-next-1673339651.0

/home/runner/work/_temp/_runner_file_commands/step_summary_0e1bebe1-6909-40ff-af3e-efd2a6446574

@codecov
Copy link
codecov bot commented Jan 10, 2023

Codecov Report

Base: 57.49% // Head: 57.50% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (dea2e58) compared to base (9988799).
Patch coverage: 36.53% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##            v2.21    #2183   +/-   ##
=======================================
  Coverage   57.49%   57.50%           
=======================================
  Files        1286     1286           
  Lines       80542    80514   -28     
  Branches    16853    16853           
=======================================
- Hits        46307    46297   -10     
+ Misses      31119    31107   -12     
+ Partials     3116     3110    -6
Flag Coverage Δ
jsdom 52.26% <36.53%> (+0.01%) ⬆️
node 15.88% <3.20%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/components/src/recycle-tree/tree/Tree.ts 88.88% <ø> (-1.59%) ⬇️
...re-browser/src/keyboard/keyboard-layout-service.ts 90.52% <ø> (ø)
packages/core-browser/src/keyboard/keys.ts 79.55% <0.00%> (ø)
...wser/view/breakpoints/debug-breakpoints.service.ts 79.59% <ø> (ø)
...sion/src/browser/sumi/contributes/browser-views.ts 67.27% <0.00%> (ø)
...on/src/browser/vscode/contributes/configuration.ts 67.74% <ø> (ø)
...tension/src/hosted/api/vscode/ext.host.treeview.ts 57.72% <ø> (+0.27%) ⬆️
...aco/src/browser/monaco-snippet-suggest-provider.ts 28.00% <0.00%> (ø)
...s/monaco/src/browser/monaco.resolved-keybinding.ts 12.06% <0.00%> (ø)
...ext/src/browser/contribution/terminal.lifecycle.ts 0.00% <0.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hacke2
Copy link
Member
hacke2 commented Jan 11, 2023

注册的时候有，不一定代表卸载的时候有，这个问题出现在切换极速版组件的情况下

@AhkunTa AhkunTa merged commit 4cc2a17 into v2.21 Jan 11, 2023
@AhkunTa AhkunTa deleted the fix/resizeObserver-unobserve-element-error branch January 11, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytemain bytemain bytemain approved these changes

@erha19 erha19 erha19 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AhkunTa @hacke2 @erha19 @bytemain