fix(editor): add missing edit stack when save #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74b1757
to
b1ce0ed
Compare
erha19
approved these changes
Jan 11, 2023
Codecov ReportBase: 59.61% // Head: 57.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2192 +/- ##
==========================================
- Coverage 59.61% 57.79% -1.82%
==========================================
Files 1327 1316 -11
Lines 94968 82981 -11987
Branches 21098 17263 -3835
==========================================
- Hits 56612 47957 -8655
+ Misses 34599 31830 -2769
+ Partials 3757 3194 -563
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
close: #1906
研究发现：
输入第二个字符按保存后，monaco editor 并没有把这个变更 push 到 editStack 中。
但是这个时候，点击一下编辑器，这个变更就被 push 到 stack 里了。
也就是说，保存的时候补偿一个 pushStack 应该就好了
Changelog
add missing edit stack when save