[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Windows/aarch64 #181

Closed
wants to merge 2 commits into from
Closed

Conversation

justsmth
Copy link
Contributor
@justsmth justsmth commented Jul 10, 2023

Issues:

N/A

Description of changes:

  • A few of our tests compare results between ring and aws-lc-rs -- however, ring currently does not support Windows/aarch64: Windows arm64 support (aarch64-pc-windows-msvc) briansmith/ring#1167
  • Disables assembly-language implementations in AWS-LC when compiling on Windows/aarch64. (The AWS-LC build fails unless -DOPENSSL_NO_ASM=1 is used.) The performance will be slower for users on Windows/aarch64, but it unblocks developers using that platform.

Call-outs:

N/A

Testing:

I tested locally in Windows via Parallels Desktop on an M1 Mac.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner July 10, 2023 14:03
@justsmth justsmth marked this pull request as draft July 10, 2023 17:56
@justsmth justsmth closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants