[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put ProGuard rules #5

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Put ProGuard rules #5

merged 1 commit into from
Mar 30, 2023

Conversation

itochan
Copy link
Contributor
@itochan itochan commented Mar 30, 2023 •
edited
Loading

It is necessary to add rules when using ProGuard's optimization settings.
Without the rule, the annotation is considered unused and will be deleted.

This PR bundles the rules into a library for use in Android.
https://developer.android.com/studio/build/shrink-code?hl=en

@itochan itochan self-assigned this Mar 30, 2023
@itochan itochan marked this pull request as ready for review March 30, 2023 06:27
@itochan itochan requested a review from takahirom March 30, 2023 06:27
@takahirom
Copy link
Contributor

👀

takahirom
takahirom approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor
@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎏

@takahirom takahirom merged commit 75f94fa into main Mar 30, 2023
@momomomo111 momomomo111 deleted the add-proguard-rules branch June 19, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees

@itochan itochan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itochan @takahirom