Maintain Script Update #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
スクリプトの変更
takahirom
reviewed
Jun 22, 2023
| ).maintain( | ||
| locationSarif = "./lint-results.sarif", | ||
| labelName = "featureflag-expiration", | ||
| assignerAlternative = "{Alternative assignor's GitHub UserId}" |
There was a problem hiding this comment.
ちょっと長いですが、fallbackAssigneeWhenOwnerNotPresentにしちゃってもいいかも (現状コード見ないと何するのかよくわからない感じがあります。)
There was a problem hiding this comment.
Oh, I forgot to use English. But how about using fallbackAssigneeWhenOwnerNotPresent so that we can see what the code will do without seeing the code.
There was a problem hiding this comment.
I agree with that opinion. I know it's a little long winded, but I think it's a good idea to prioritize readability.
takahirom
reviewed
Jun 22, 2023
| repoName = System.getenv("GITHUB_REPOSITORY"), | ||
| headSha = System.getenv("HEAD_SHA") | ||
| ).maintain( | ||
| locationSarif = "./lint-results.sarif", |
There was a problem hiding this comment.
How about using sarifLocation 👀
There was a problem hiding this comment.
Sorry how about sarifFilePath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the following major changes:
• Modified to declare environment variables such as TOKEN and SHA from the outside
• Added the ability to assign someone else if the flag owner is not a collaborator in the Repository
• Removed unnecessary environment variables