-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs related to EXPIRY_DATE_NOT_DEFINED #31
Conversation
…Y_DATE_NOT_DEFINED EXPIRY_DATE_NOT_DEFINEDなのにも関わらずエラーが吐かれるバグを修正
if (expiryDate == FlagType.EXPIRY_DATE_INFINITE) { | ||
reportInfiniteExpiryDateErrorIfNeeded(qualifiedName, context, element, location) | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prioritize giving warnings when WorkInProgress and Experiment contain EXPIRY_DATE_INFINITE.
val expiryDate = (annotationAttributes.firstOrNull { it.name == "expiryDate" } | ||
?.evaluate() as String?) ?: "" | ||
if (expiryDate == FlagType.EXPIRY_DATE_INFINITE) { | ||
reportInfiniteExpiryDateErrorIfNeeded(qualifiedName, context, element, location) | ||
return | ||
} | ||
if (owner == FlagType.OWNER_NOT_DEFINED || expiryDate == FlagType.EXPIRY_DATE_NOT_DEFINED) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate on why you use owner here? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I don't use the OWNER parameter. Thanks for pointing that out to me.🙏
不要なパラメーター判定の削除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📅
Fixed the issue where a warning to set the deadline in the correct format was displayed even when
OWNER_DATE_NOT_DEFINED andEXPIRY_DATE_NOT_DEFINED were set.