[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test teardown in __init.test.js synchronous #5477

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

mrxz
Copy link
Contributor
@mrxz mrxz commented Feb 27, 2024

Description:
Removing the timeout from the teardown in __init.test.js speeds up test execution significantly on my machine. According to the accompanying comment this timeout is there to let detachCallbacks clean themselves up before considering the teardown complete. However, custom elements v1 uses disconnectedCallback which is (effectively) synchronous, and therefore the setTimeout should have no bearing on them.

Removing the timeout doesn't seem to have a negative impact. All tests are still green after making this change.

Changes proposed:

  • Make teardown synchronous in __init.test.js speeding up tests

@dmarcos
Copy link
Member
dmarcos commented Feb 27, 2024

Thanks

@dmarcos dmarcos merged commit 374ae6c into aframevr:master Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants