-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test stack #5091
Update test stack #5091
Conversation
I updated all test dependencies. I didn't touch any build (browserify) or runtime (polyfills) dependencies. Are you interested in setting up Github Actions to run the tests like we did for networked-aframe? |
What's the benefit of updating the dependencies? I usually only like to update when there's a reason to do so. |
We used to have travis-ci running the tests per commit. Never got around to investigate why it broke: See commits Aug 2021 and earlier (x or tick next to the commit). Any ideas? |
4328ceb
to
d9db8aa
Compare
Travis stopped offering CI minutes for open source projects at that time, travis.org was shut down. Updating the versions is just a matter of keeping them up to date to versions that are maintained, mainly for vulnerabilities, although for a test stack this is probably not as important. |
I saw that message but not clear what that meant. I assume travis-co.com is now a paid product. no longer free? Where do the test run with your Github Actions setup? |
That's right.
On Github. Github does CI now with Github Actions. |
I looked at the current
For networked-aframe, I disabled Firefox in the CI and only test on Chrome. I had flaky tests on Firefox. Having random test failure in CI is bad because at one point you won't look at those failures anymore. For codecov, I don't know how it works, but the badge is at 0% as well, so may not be working anymore, maybe since travis was down? |
Ok I found it, coverage was setup in #1783
|
For codecov, the old uploader has been shut down as well. We need to remove codecov dependency and script in |
I successfully set up GitHub Actions in #5092. |
Thanks! |
Update the test stack to latest versions.
Merge this once the other two PR has been merged: