[source-mongodb] add subtype when converting binary #42927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Good find! |
rodireich
reviewed
Aug 16, 2024
| @@ -128,7 +141,7 @@ private Bson buildFilter() { | |||
| case OBJECT_ID -> new BsonObjectId(new ObjectId(state.id())); | |||
| case INT -> new BsonInt32(Integer.parseInt(state.id())); | |||
| case LONG -> new BsonInt64(Long.parseLong(state.id())); | |||
| case BINARY -> parseBinaryIdString(state.id()); | |||
| case BINARY -> parseBinaryIdString(state.id(), state.binarySubType()); | |||
There was a problem hiding this comment.
This is intended to ensure there's no multiple binary subtype of binary _id on a single collection.
Am I reading it correctly?
There was a problem hiding this comment.
not really - this is to make sure we write the correct filter when querying mongo from record iterator
...ngodb-v2/src/main/java/io/airbyte/integrations/source/mongodb/state/MongoDbStateManager.java
Outdated
Show resolved
Hide resolved
...ongodb-v2/src/main/java/io/airbyte/integrations/source/mongodb/state/MongoDbStreamState.java
Outdated
Show resolved
Hide resolved
rodireich
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#40525
for binary typed
_id, we first base64 encode them into a readable string, and decode it back to binary and send to mongo as a cursor anchor.When decoding it back to binary, we should also take binary subtype into consideration, otherwise it won't be converted back to the original value.
How
In state message we will also need to track binSubtype. normally it should be null, unless the parent type is Binary. To migrate existing state where it does not have this new type, it will be defaulted to Binary(subtype 0)
Review guide
User Impact
Can this PR be safely reverted and rolled back?