The latest updates on your projects. Learn more about Vercel for Git ↗︎

@kev-datams The Changes make sense to me. I just wanted to check the regression results, but we have some problem rendering them for now. I will check if I can get that fixed.

In the meantime, some unit tests are broken, probably because of the change In the requests. Can you take a look at those?

@kev-datams The Changes make sense to me. I just wanted to check the regression results, but we have some problem rendering them for now. I will check if I can get that fixed.

In the meantime, some unit tests are broken, probably because of the change In the requests. Can you take a look at those?

Also please when fixing the test rebase from master, seems is what we need to have regression working on the branch. Thanks!

Hi @aldogonzalez8,
Just fixed the unit tests, no remaining failure right now 👍
Also rebased from master as requested
Please could you have a look and accept/merge ASAP ? 🙏

NB: any idea about the complementary fix on the "third point" of the issue ?

Hi @kev-datams, there was a problem in unit tests unrelated to your changes that I just fixed. Can you please rebase from master again? I will rerun tests after that.

Hi @kev-datams, there was a problem in unit tests unrelated to your changes that I just fixed. Can you please rebase from master again? I will rerun tests after that.

Hi @aldogonzalez8, done 🙏

All checks have passed
12 skipped and 21 successful checks

🔥

@kev-datams I was just informed that regression won't work in the CI process for a fork, but I can clone your repository locally and run regression from here. Your changes seem pretty straightforward, but I want to be sure. I will get back to you on this.

@kev-datams I was just informed that regression won't work in the CI process for a fork, but I can clone your repository locally and run regression from here. Your changes seem pretty straightforward, but I want to be sure. I will get back to you on this.

@aldogonzalez8, do you know if there is any alternative on our side to save time for future PR and limit workload on your side?

but OK, waiting for your confirmation to merge 🙏

Sorry for the delay, I can see your changes in the regressions report, and the response data seems now contain info related to the request :)

APPROVED

thanks @aldogonzalez8 🔥
what is the next step to merge it and generate the updated connector ?

If squash and merge available for you? If not, maybe it is something I have to push.

If squash and merge available for you? If not, maybe it is something I have to push.

Ok, I just merged, the new version should be available in a few minutes.

Thanks a lot !