[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for nullable top-level schemas #44401

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Fix for nullable top-level schemas #44401

merged 7 commits into from
Aug 19, 2024

Conversation

johnny-schmidt
Copy link
Contributor

@johnny-schmidt johnny-schmidt requested review from a team as code owners August 19, 2024 17:31
@vercel Vercel
Copy link
vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 10:49pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/s3 labels Aug 19, 2024
evantahler
evantahler approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor
@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
You'll need to bump the connector version & docs too

edgao
edgao reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor
@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blegh. if you have an easy way to test - what happens if the top-level schema is type: [string, object]? (we've seen that in the past also)

@johnny-schmidt
Copy link
Contributor Author

blegh. if you have an easy way to test - what happens if the top-level schema is type: [string, object]? (we've seen that in the past also)

@edgao we would not be able to handle that in avro anyway. What would the top-level string field be called? The field names come from the object properties.

@johnny-schmidt johnny-schmidt force-pushed the issue-6269/destination-s3-respects-nullable-top-level-schema branch from 154e7ff to 77c1f9d Compare August 19, 2024 17:39
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 19, 2024
@johnny-schmidt
Copy link
Contributor Author
johnny-schmidt commented Aug 19, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10458233305
❌ Publish Java CDK version=0.44.15 failed!

@johnny-schmidt
Copy link
Contributor Author
johnny-schmidt commented Aug 19, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10458694678

@johnny-schmidt johnny-schmidt force-pushed the issue-6269/destination-s3-respects-nullable-top-level-schema branch from 9fec536 to 500d2e0 Compare August 19, 2024 18:25
@johnny-schmidt
Copy link
Contributor Author
johnny-schmidt commented Aug 19, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10458851761
✅ Successfully published Java CDK version=0.44.15!

@johnny-schmidt
Copy link
Contributor Author
johnny-schmidt commented Aug 19, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk force=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/10462082379

@johnny-schmidt
Copy link
Contributor Author
johnny-schmidt commented Aug 19, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk force=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/10462117821
✅ Successfully published Java CDK version=0.44.15!

@johnny-schmidt johnny-schmidt merged commit 2ef1a5a into master Aug 19, 2024
37 checks passed
@johnny-schmidt johnny-schmidt deleted the issue-6269/destination-s3-respects-nullable-top-level-schema branch August 19, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao left review comments

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnny-schmidt @evantahler @edgao @octavia-squidington-iii