bulk-cdk-core-base: InputState validation tweaks #44827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
tryangul
reviewed
Aug 27, 2024
| @@ -35,6 +35,8 @@ class InputStateFactory { | |||
| ): InputState { | |||
| val list: List<AirbyteStateMessage> = | |||
| ValidatedJsonUtils.parseList(AirbyteStateMessage::class.java, json ?: "[]") | |||
| // Discard states messages with unset type to allow {} as a valid input state. | |||
| .filter { it.type != null } | |||
theyueli
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Context: https://airbytehq-team.slack.com/archives/C043JHEEYKG/p1724697591711879
It turns out that
{}is expected to be a valid input for the--stateCLI argument, same as[]. This PR makes this possible; presently theInputStateFactoryvalidation method throws aConfigErrorException.How
Ignore input objects where the
typefield is not set. Perform stricter validation when it is set.Review guide
User Impact
Manually editing the input state to
{}is now possible for any source connectors built using the Bulk CDK.Can this PR be safely reverted and rolled back?