Support raw mode for posix in native image #186
Merged
+67
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with `Expected Object but got Word` when compiling the native image comes from the fact that the kotlin compiler insert null checks if the used types are not nullable. For example, if we declare tcgetattr as ```kotlin @cfunction("tcgetattr") external fun tcgetattr(fd: Int, termios: termios): Int ``` Every call to it will be compiled as ```kotlin Intrinsics.checkNotNull(termios); tcgetattr(..., termios); ``` It is possible to disable those checks with the following compiler parameters: -Xno-param-assertions, -Xno-call-assertions,-Xno-receiver-assertions. But in this case, it is enough to simply mark the termios parameter as nullable.
hubvd
commented
Jul 8, 2024
| @@ -39,15 +39,6 @@ class GraalSmokeTest { | |||
| future.get(1000, TimeUnit.MILLISECONDS) | |||
| } | |||
|
|
|||
| @Ignore("Raw mode is currently unsupported on native-image") | |||
There was a problem hiding this comment.
If we remove the assertThrows, this test fails with Inappropriate ioctl for device
Actually, when using the native-build-tools plugins, every test is run two times. Once on the JVM to discover the tests, and a second time in native-image mode. It first fails when using JNA
com.sun.jna.LastErrorException: [25] Inappropriate ioctl for device
at app//com.sun.jna.Native.invokeVoid(Native Method)
at app//com.sun.jna.Function.invoke(Function.java:418)
at app//com.sun.jna.Function.invoke(Function.java:364)
at app//com.sun.jna.Library$Handler.invoke(Library.java:270)
at app//com.github.ajalt.mordant.internal.syscalls.jna.$Proxy16.tcgetattr(Unknown Source)
at app//com.github.ajalt.mordant.internal.syscalls.jna.SyscallHandlerJnaLinux.getStdinTermios(SyscallHandler.jna.linux.kt:86)
at app//com.github.ajalt.mordant.internal.syscalls.SyscallHandlerPosix.enterRawMode(SyscallHandler.posix.kt:162)
at app//com.github.ajalt.mordant.input.RawModeKt.enterRawMode(RawMode.kt:21)
at app//com.github.ajalt.mordant.input.RawModeKt.enterRawMode$default(RawMode.kt:17)
at app//com.github.ajalt.mordant.graalvm.GraalSmokeTest.raw mode test(GraalSmokeTest.kt:45)
at java.base@21.0.3/java.lang.reflect.Method.invoke(Method.java:580)
at java.base@21.0.3/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base@21.0.3/java.util.ArrayList.forEach(ArrayList.java:1596)
But if we rewrite the test as
@Test
fun `raw mode test`() {
val imageCode = System.getProperty("org.graalvm.nativeimage.imagecode")
val isNativeImage = imageCode == "buildtime" || imageCode == "runtime"
if (!isNativeImage) {
return
}
val t = Terminal(interactive = true)
t.enterRawMode().use {}
}If fails the same way Error reading terminal attributes
I don't think it's possible to run this from a gradle test, so I removed it
|
My bad for not mentioning this in the initial native-image PR, it also took me quite a while to figure this out. |
|
Amazing! I have no idea how you figured this out. Thank you! The tests are failing because a struct definition is wrong on macos, but that's my fault, not yours. I'll merge now and fix it is a separate PR. |
ajalt
added a commit
that referenced
this pull request
Jul 9, 2024
This is a follow on to #186 that fixes the `termios` struct definition on macos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with
Expected Object but got Wordwhen compiling the native image comes from the fact that the kotlin compiler insert null checks if the used types are not nullable.For example, if we declare tcgetattr as
Every call to it will be compiled as
It is possible to disable those checks with the following compiler parameters:
-Xno-param-assertions, -Xno-call-assertions,-Xno-receiver-assertions.
But in this case, it is enough to simply mark the termios parameter as nullable.