[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update-deps): address security vulnerability and update dependencies #21

Merged
6 commits merged into from
Jan 16, 2020

Conversation

Francois-Esquire
Copy link
Contributor
@Francois-Esquire Francois-Esquire commented Dec 25, 2019

updating packages and removed security vulnerabilities.

Many of the changes came as a result of eslint updates and the added rules. I've consolidated all .eslintrc.json config to the root project to make configuration easier to update in the future for all the packages.

@claassistantio
Copy link
claassistantio commented Dec 25, 2019

CLA assistant check
All committers have signed the CLA.

@Francois-Esquire Francois-Esquire changed the title bugfix(update-deps): address security vulnerability fix(update-deps): address security vulnerability Dec 25, 2019
@Francois-Esquire Francois-Esquire changed the title fix(update-deps): address security vulnerability fix(update-deps): address security vulnerability and update dependencies Dec 26, 2019
.eslintrc.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/parrot-devtools/src/app/components/Middleware.jsx Outdated Show resolved Hide resolved
packages/parrot-devtools/src/app/components/Settings.jsx Outdated Show resolved Hide resolved
packages/parrot-devtools/src/app/index.js Outdated Show resolved Hide resolved
@ghost
Copy link
ghost commented Jan 6, 2020

@Francois-Esquire FYI: This repo is out of sync with the internal code base. We're planning to sync this week.

Please don't merge this PR until after the sync is complete.

package.json Show resolved Hide resolved
@Francois-Esquire Francois-Esquire force-pushed the bugfix/npm_insecure_deps branch 2 times, most recently from 13b7879 to d129a83 Compare January 10, 2020 17:26
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebuild the two .zip files for parrot-devtools and commit those?

@Francois-Esquire Francois-Esquire requested review from mtomcal and a user January 14, 2020 17:15
@Francois-Esquire
Copy link
Contributor Author

@jgolden17 I've built the devtools and pushed up the changes, should be good now
@mtomcal Tested the devtools and it runs locally

Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ghost ghost merged commit 423316c into master Jan 16, 2020
@Francois-Esquire Francois-Esquire deleted the bugfix/npm_insecure_deps branch January 17, 2020 18:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants