[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Remove unused imports and module object names #54070

Closed

Conversation

ChellappanRajan
Copy link
Contributor

Cleaned up the core package folder by removing all unused imports

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from alxhub January 25, 2024 11:56
Cleaned up the core package folder by removing all unused imports
@JeanMeche JeanMeche added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime labels Jan 25, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 25, 2024
@pkozlowski-opensource
Copy link
Member

Thnx for the cleanup @ChellappanRajan - while we appreciate it, it also looks like this PR got stalled. Would you mind rebasing?

@pkozlowski-opensource pkozlowski-opensource added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 4, 2024
@ChellappanRajan
Copy link
Contributor Author

Thnx for the cleanup @ChellappanRajan - while we appreciate it, it also looks like this PR got stalled. Would you mind rebasing?

Hi @pkozlowski-opensource In the recent code most of the unused codes are remove hence closing this PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants