feat(core): support TypeScript 5.5 #56096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added a commit
to crisbeto/dev-infra
that referenced
this pull request
May 27, 2024
Currently some places import the `ts_library` from the node_modules while others import it from `defaults.bzl`. This causes a mismatch in the `target` that ends up being used and breaking angular/angular#56096. These changes switch the imports to go through `defaults.bzl`.
crisbeto
added a commit
to crisbeto/dev-infra
that referenced
this pull request
May 27, 2024
Currently some places import the `ts_library` from the node_modules while others import it from `defaults.bzl`. This causes a mismatch in the `target` that ends up being used and breaking angular/angular#56096. These changes switch the imports to go through `defaults.bzl`.
crisbeto
added a commit
to crisbeto/dev-infra
that referenced
this pull request
May 27, 2024
Currently the default `target` for the code compiled with `ts_library` is set through the `ts_library` exposed in `defaults.bzl`, however the code under the `bazel` directory isn't allowed to use `defaults.bzl` which meant that it was defaulting to es2015. These changes add a `defaults.bzl` specific to the `bazel` directory which allows us to maintain the defaults in a single place. This came up due to a breakage in angular/angular#56096.
crisbeto
added a commit
to crisbeto/dev-infra
that referenced
this pull request
May 27, 2024
Currently the default `target` for the code compiled with `ts_library` is set through the `ts_library` exposed in `defaults.bzl`, however the code under the `bazel` directory isn't allowed to use `defaults.bzl` which meant that it was defaulting to es2015. These changes add a `defaults.bzl` specific to the `bazel` directory which allows us to maintain the defaults in a single place. This came up due to a breakage in angular/angular#56096.
crisbeto
added a commit
to crisbeto/dev-infra
that referenced
this pull request
May 27, 2024
Currently the default `target` for the code compiled with `ts_library` is set through the `ts_library` exposed in `defaults.bzl`, however the code under the `bazel` directory isn't allowed to use `defaults.bzl` which meant that it was defaulting to es2015. These changes add a `defaults.bzl` specific to the `bazel` directory which allows us to maintain the defaults in a single place. This came up due to a breakage in angular/angular#56096.
crisbeto
added a commit
to crisbeto/dev-infra
that referenced
this pull request
May 27, 2024
Currently the default `target` for the code compiled with `ts_library` is set through the `ts_library` exposed in `defaults.bzl`, however the code under the `bazel` directory isn't allowed to use `defaults.bzl` which meant that it was defaulting to es2015. These changes add a `defaults.bzl` specific to the `bazel` directory which allows us to maintain the defaults in a single place. This came up due to a breakage in angular/angular#56096.
devversion
pushed a commit
to angular/dev-infra
that referenced
this pull request
May 27, 2024
Currently the default `target` for the code compiled with `ts_library` is set through the `ts_library` exposed in `defaults.bzl`, however the code under the `bazel` directory isn't allowed to use `defaults.bzl` which meant that it was defaulting to es2015. These changes add a `defaults.bzl` specific to the `bazel` directory which allows us to maintain the defaults in a single place. This came up due to a breakage in angular/angular#56096.
4a8f2d4
to
9001876
Compare
crisbeto
commented
May 28, 2024
| // changing since TypeScript will `switchToScriptVersionCache` when a file is opened. | ||
| // Note that this emulates what we have to do in the server/extension as well. | ||
| // TODO: remove this once PR #41475 lands | ||
| this.tsProject.markAsDirty(); |
There was a problem hiding this comment.
Context here is that the markAsDirty method doesn't exist anymore and the TODO above mentioned that it should've been removed a long time ago.
crisbeto
commented
May 28, 2024
| @@ -3375,7 +3375,7 @@ runInEachFileSystem((os: string) => { | |||
|
|
|||
| env.driveMain(); | |||
| const jsContents = env.getContents('test.js'); | |||
| expect(jsContents).toMatch(/function Test_Factory\(t\) { i0\.ɵɵinvalidFactory\(\)/ms); | |||
| expect(jsContents).toMatch(/function Test_Factory\(t\) { i0\.ɵɵinvalidFactory\(\)/m); | |||
There was a problem hiding this comment.
The s flag wasn't doing anything here so I removed it.
crisbeto
commented
May 28, 2024
| newText, | ||
| { | ||
| // Not passing the implied Node format appears not break program reuse in TS 5.5. | ||
| impliedNodeFormat: undefined, |
There was a problem hiding this comment.
This one took a while to track down, but for some reason omitting the impliedNodeFormat prevented the program from being reused. It showed up in our own unit tests as well.
crisbeto
commented
May 28, 2024
| @@ -83,6 +83,10 @@ export function typeToValue( | |||
| return typeOnlyImport(typeNode, firstDecl); | |||
| } | |||
|
|
|||
| if (!ts.isImportDeclaration(firstDecl.parent)) { | |||
There was a problem hiding this comment.
This is necessary, because import clauses can now be inside ImportDeclaration or JSDocImportTag.
clydin
reviewed
May 28, 2024
| @@ -171,7 +171,7 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "0.0.0-PLACEHOLDE | |||
| type: Directive, | |||
| args: [{ | |||
| standalone: true, | |||
| selector: '[direct]', | |||
There was a problem hiding this comment.
The trailing comma removal is adding a large amount to the diff for this PR. Is this something that is expected and can we fix that somehow? Keeping the trailing commas would better align with the formatting throughout the rest of the repo.
There was a problem hiding this comment.
It's the sort of thing that TS changes once in a while for no reason. We might be able to get it back, but I'm not sure it's worth the hassle just for this one PR.
Updates the repo to add support for TypeScript 5.5. Includes resolving some compilation errors and broken tests.
alxhub
approved these changes
May 28, 2024
|
This is still missing approvals for
|
|
This PR was merged into the repository by commit e5a6f91. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the repo to add support for TypeScript 5.5. Includes resolving some compilation errors and broken tests.