[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): do not activate event replay when no events are registered #56509

Closed
wants to merge 2 commits into from
Closed

fix(core): do not activate event replay when no events are registered #56509

wants to merge 2 commits into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit adds extra checks to handle a situation when an application has no events configured, but the Event Replay feature was enabled. This situation can happen when some routes in an application are mostly static, when other routes are more interactive.

Resolves #56423.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release core: event dispatch labels Jun 19, 2024
@ngbot ngbot bot modified the milestone: Backlog Jun 19, 2024
@AndrewKushnir AndrewKushnir mentioned this pull request Jun 19, 2024
Closed
@AndrewKushnir
fix(core): do not activate event replay when no events are registered
826bf77 
This commit adds extra checks to handle a situation when an application has no events configured, but the Event Replay feature was enabled. This situation can happen when some routes in an application are mostly static, when other routes are more interactive.

Resolves angular#56423.
@AndrewKushnir
refactor(core): use performance API for Event Replay
27bc446 
This commit adds a standard performance marker that can be viewed in Chrome dev tools and other tooling.
See more info at https://developer.mozilla.org/en-US/docs/Web/API/Performance/mark
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 19, 2024
@AndrewKushnir AndrewKushnir removed the request for review from thePunderWoman June 19, 2024 20:57
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Jun 20, 2024
@AndrewKushnir
Copy link
Contributor Author

Caretaker note: current approvals should be enough to proceed with the merge.

@AndrewKushnir
Copy link
Contributor Author

This PR was merged into the repository by commit e20c6df.

The changes were merged into the following branches: main, 18.0.x

AndrewKushnir added a commit that referenced this pull request Jun 20, 2024
@AndrewKushnir
refactor(core): use performance API for Event Replay (#56509)
e20c6df 
This commit adds a standard performance marker that can be viewed in Chrome dev tools and other tooling.
See more info at https://developer.mozilla.org/en-US/docs/Web/API/Performance/mark

PR Close #56509
AndrewKushnir added a commit that referenced this pull request Jun 20, 2024
@AndrewKushnir
fix(core): do not activate event replay when no events are registered (…
83ffa94 
…#56509)

This commit adds extra checks to handle a situation when an application has no events configured, but the Event Replay feature was enabled. This situation can happen when some routes in an application are mostly static, when other routes are more interactive.

Resolves #56423.

PR Close #56509
AndrewKushnir added a commit that referenced this pull request Jun 20, 2024
@AndrewKushnir
refactor(core): use performance API for Event Replay (#56509)
69e0aa5 
This commit adds a standard performance marker that can be viewed in Chrome dev tools and other tooling.
See more info at https://developer.mozilla.org/en-US/docs/Web/API/Performance/mark

PR Close #56509
This was referenced Jul 12, 2024
Closed
Closed
@MrDari MrDari mentioned this pull request Jul 12, 2024
Open
@juanponton5 juanponton5 mentioned this pull request Jul 12, 2024
Open
@crokenx crokenx mentioned this pull request Jul 12, 2024
Open
@ambrose40 ambrose40 mentioned this pull request Jul 12, 2024
Open
@JAER12392 JAER12392 mentioned this pull request Jul 13, 2024
Open
This was referenced Jul 14, 2024
Closed
Closed
@MrDari MrDari mentioned this pull request Jul 15, 2024
Open
This was referenced Jul 15, 2024
Open
Open
@crokenx crokenx mentioned this pull request Jul 15, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
@q1blue q1blue mentioned this pull request Jul 16, 2024
Open
@saxenakshitiz saxenakshitiz mentioned this pull request Jul 17, 2024
Closed
@SaulReyes-ux SaulReyes-ux mentioned this pull request Jul 17, 2024
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iteriani iteriani iteriani approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

setTimeout in interceptor causes error with/in EventReplay
2 participants
@AndrewKushnir @iteriani