[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add more team members into the public-api group #56743

Closed
wants to merge 1 commit into from
Closed

ci: add more team members into the public-api group #56743

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit adds more team members into the public-api group, so that they can approve public API changes, but they would not be requested for reviews by PullApprove (to avoid requests for unrelated changes).

PR Type

What kind of change does this PR introduce?

  • CI related changes

@AndrewKushnir
ci: add more team members into the public-api group
c504913 
This commit adds more team members into the `public-api` group, so that they can approve public API changes, but they would not be requested for reviews by PullApprove (to avoid requests for unrelated changes).
@AndrewKushnir AndrewKushnir added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 27, 2024
thePunderWoman
thePunderWoman approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor
@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 27, 2024
thePunderWoman pushed a commit that referenced this pull request Jun 27, 2024
@AndrewKushnir @thePunderWoman
ci: add more team members into the public-api group (#56743)
ef41fdd 
This commit adds more team members into the `public-api` group, so that they can approve public API changes, but they would not be requested for reviews by PullApprove (to avoid requests for unrelated changes).

PR Close #56743
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 917cd14.

The changes were merged into the following branches: main, 18.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrewKushnir @thePunderWoman