Enable avoid_redundant_argument_values lint (flutter#91409) (flutter#…

…91462)
andrewkolos · Oct 8, 2021 · 61a0add · 61a0add
1 parent ac88d4b
commit 61a0add
Show file tree

Hide file tree

Showing 667 changed files with 1,694 additions and 3,386 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -74,7 +74,7 @@ linter:
     # - avoid_positional_boolean_parameters # would have been nice to enable this but by now there's too many places that break it
     - avoid_print
     # - avoid_private_typedef_functions # we prefer having typedef (discussion in https://github.com/flutter/flutter/pull/16356)
-    # - avoid_redundant_argument_values # not yet tested
+    - avoid_redundant_argument_values
     - avoid_relative_lib_imports
     - avoid_renaming_method_parameters
     - avoid_return_types_on_setters

diff --git a/dev/benchmarks/complex_layout/lib/main.dart b/dev/benchmarks/complex_layout/lib/main.dart
@@ -370,7 +370,6 @@ class UserHeader extends StatelessWidget {
           ),
           Expanded(
             child: Column(
-              mainAxisAlignment: MainAxisAlignment.start,
               crossAxisAlignment: CrossAxisAlignment.stretch,
               children: <Widget>[
                 RichText(text: TextSpan(
@@ -569,7 +568,6 @@ class BottomBar extends StatelessWidget {
         border: Border(
           top: BorderSide(
             color: Theme.of(context).dividerColor,
-            width: 1.0,
           ),
         ),
       ),

diff --git a/dev/benchmarks/complex_layout/test_memory/scroll_perf.dart b/dev/benchmarks/complex_layout/test_memory/scroll_perf.dart
@@ -28,7 +28,6 @@ Future<void> main() async {
     },
     behavior: HitTestBehavior.opaque,
     child: const IgnorePointer(
-      ignoring: true,
       child: ComplexLayoutApp(),
     ),
   ));

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/color_filter_and_fade.dart b/dev/benchmarks/macrobenchmarks/lib/src/color_filter_and_fade.dart
@@ -147,7 +147,6 @@ class _ShadowWidget extends StatelessWidget {
         ),
         size: Size(width, height),
         isComplex: true,
-        willChange: false,
       ),
     );
   }

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/filtered_child_animation.dart b/dev/benchmarks/macrobenchmarks/lib/src/filtered_child_animation.dart
@@ -73,7 +73,6 @@ class _FilteredChildAnimationPageState extends State<FilteredChildAnimationPage>
       color: Colors.green,
       boxShadow: complex ? <BoxShadow>[
         const BoxShadow(
-          color: Colors.black,
           blurRadius: 10.0,
         ),
       ] : null,

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/multi_widget_construction.dart b/dev/benchmarks/macrobenchmarks/lib/src/multi_widget_construction.dart
@@ -32,7 +32,6 @@ class _MultiWidgetConstructTableState extends State<MultiWidgetConstructTable>
     _controller = AnimationController(
       vsync: this,
       duration: const Duration(milliseconds: 10000),
-      lowerBound: 0,
       upperBound: colorList.length + 1.0,
     )..repeat();
   }

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/web/bench_pageview_scroll_linethrough.dart b/dev/benchmarks/macrobenchmarks/lib/src/web/bench_pageview_scroll_linethrough.dart
@@ -113,7 +113,7 @@ class _CustomPainter extends CustomPainter {
 
       _textPainter.text = span;
 
-      _textPainter.layout(minWidth: 0, maxWidth: width);
+      _textPainter.layout(maxWidth: width);
       _linePainter.style = PaintingStyle.fill;
       canvas.drawRect(
           Rect.fromLTWH(xPosition, yPosition - viewPadding, width, height),

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/web/bench_paths_recording.dart b/dev/benchmarks/macrobenchmarks/lib/src/web/bench_paths_recording.dart
@@ -1833,7 +1833,7 @@ void pathOps78() {
 
 void pathOps79() {
   final Path path79 = Path();
-  path79.addRRect(RRect.fromRectAndCorners(const Rect.fromLTRB(0, 0, 64, 56), topLeft: Radius.zero, topRight: Radius.zero, bottomLeft: const Radius.circular(10), bottomRight: Radius.zero, ));
+  path79.addRRect(RRect.fromRectAndCorners(const Rect.fromLTRB(0, 0, 64, 56), bottomLeft: const Radius.circular(10), ));
   gFillType = path79.fillType;
   path80 = path79.shift(const Offset(906, 136));
   gFillType = path79.fillType;
@@ -5828,7 +5828,7 @@ void pathOps576() {
   path576.moveTo(0, 0);
   path576.lineTo(220.60000000000002, 0);
   path576.quadraticBezierTo(235.60000000000002, 0, 237.569696969697, 7.817946907441011);
-  path576.arcToPoint(const Offset(299.630303030303, 7.817946907441011), radius: const Radius.circular(32), rotation: 0, largeArc: false, clockwise: false);
+  path576.arcToPoint(const Offset(299.630303030303, 7.817946907441011), radius: const Radius.circular(32), clockwise: false);
   path576.quadraticBezierTo(301.6, 0, 316.6, 0);
   path576.lineTo(312.6, 0);
   path576.lineTo(312.6, 48);

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/web/bench_simple_lazy_text_scroll.dart b/dev/benchmarks/macrobenchmarks/lib/src/web/bench_simple_lazy_text_scroll.dart
@@ -25,23 +25,20 @@ class BenchSimpleLazyTextScroll extends WidgetRecorder {
       child: Row(
         children: const <Widget>[
           Flexible(
-            flex: 1,
             child: _TestScrollingWidget(
               initialScrollOffset: 0,
               scrollDistance: 300,
               scrollDuration: Duration(seconds: 1),
             ),
           ),
           Flexible(
-            flex: 1,
             child: _TestScrollingWidget(
               initialScrollOffset: 1000,
               scrollDistance: 500,
               scrollDuration: Duration(milliseconds: 1500),
             ),
           ),
           Flexible(
-            flex: 1,
             child: _TestScrollingWidget(
               initialScrollOffset: 2000,
               scrollDistance: 700,

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/web/bench_text_layout.dart b/dev/benchmarks/macrobenchmarks/lib/src/web/bench_text_layout.dart
@@ -417,7 +417,6 @@ class ColorItem extends StatelessWidget {
           bottom: false,
           child: Row(
             mainAxisAlignment: MainAxisAlignment.spaceBetween,
-            crossAxisAlignment: CrossAxisAlignment.center,
             children: <Widget>[
               Text('$_counter:$prefix$index'),
               Text(colorString()),

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/web/bench_wrapbox_scroll.dart b/dev/benchmarks/macrobenchmarks/lib/src/web/bench_wrapbox_scroll.dart
@@ -155,7 +155,6 @@ class ProductOption extends StatelessWidget {
       padding: const EdgeInsets.symmetric(horizontal: 11, vertical: 5),
       decoration: BoxDecoration(
         border: Border.all(
-          width: 1,
           color: const Color(0xffebebeb),
         ),
         borderRadius: const BorderRadius.all(Radius.circular(15)),

diff --git a/dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart b/dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart
@@ -31,7 +31,7 @@ import 'src/web/recorder.dart';
 
 typedef RecorderFactory = Recorder Function();
 
-const bool isCanvasKit = bool.fromEnvironment('FLUTTER_WEB_USE_SKIA', defaultValue: false);
+const bool isCanvasKit = bool.fromEnvironment('FLUTTER_WEB_USE_SKIA');
 
 /// List of all benchmarks that run in the devicelab.
 ///

diff --git a/dev/benchmarks/macrobenchmarks/test/frame_policy.dart b/dev/benchmarks/macrobenchmarks/test/frame_policy.dart
@@ -31,11 +31,9 @@ void main() {
       final List<PointerEventRecord> records = <PointerEventRecord>[
         PointerEventRecord(Duration.zero, <PointerEvent>[
           PointerAddedEvent(
-            timeStamp: Duration.zero,
             position: location,
           ),
           PointerDownEvent(
-            timeStamp: Duration.zero,
             position: location,
             pointer: 1,
           ),

diff --git a/dev/benchmarks/microbenchmarks/lib/foundation/change_notifier_bench.dart b/dev/benchmarks/microbenchmarks/lib/foundation/change_notifier_bench.dart
@@ -167,16 +167,16 @@ void main() {
   }
 
   runAddListenerBenchmark(_kNumWarmUp, addResult: false);
-  runAddListenerBenchmark(_kNumIterations, addResult: true);
+  runAddListenerBenchmark(_kNumIterations);
 
   runNotifyListenerBenchmark(_kNumWarmUp, addResult: false);
-  runNotifyListenerBenchmark(_kNumIterations, addResult: true);
+  runNotifyListenerBenchmark(_kNumIterations);
 
   runRemoveListenerBenchmark(_kNumWarmUp, addResult: false);
-  runRemoveListenerBenchmark(_kNumIterations, addResult: true);
+  runRemoveListenerBenchmark(_kNumIterations);
 
   runRemoveListenerWhileNotifyingBenchmark(_kNumWarmUp, addResult: false);
-  runRemoveListenerWhileNotifyingBenchmark(_kNumIterations, addResult: true);
+  runRemoveListenerWhileNotifyingBenchmark(_kNumIterations);
 
   printer.printToStdout();
 }

diff --git a/dev/benchmarks/microbenchmarks/lib/geometry/curves_bench.dart b/dev/benchmarks/microbenchmarks/lib/geometry/curves_bench.dart
@@ -48,7 +48,7 @@ void main() {
     Offset(0.70, 0.04),
     Offset(0.78, 0.98),
     Offset(0.88, -0.00),
-  ], tension: 0.00);
+  ]);
   _testCurve(
     catmullRomCurve,
     name: 'catmullrom_transform_iteration',

diff --git a/dev/benchmarks/microbenchmarks/lib/language/sync_star_semantics_bench.dart b/dev/benchmarks/microbenchmarks/lib/language/sync_star_semantics_bench.dart
@@ -19,7 +19,7 @@ void main() {
   for (int i = 0; i < words.length; i++) {
     if (i.isEven) {
       data.add(
-        InlineSpanSemanticsInformation(words[i], isPlaceholder: false),
+        InlineSpanSemanticsInformation(words[i]),
       );
     } else if (i.isEven) {
       data.add(

diff --git a/dev/benchmarks/platform_views_layout_hybrid_composition/lib/android_platform_view.dart b/dev/benchmarks/platform_views_layout_hybrid_composition/lib/android_platform_view.dart
@@ -38,7 +38,6 @@ class AndroidPlatformView extends StatelessWidget {
           id: params.id,
           viewType: viewType,
           layoutDirection: TextDirection.ltr,
-          creationParams: null,
           creationParamsCodec: const StandardMessageCodec(),
         )
           ..addOnPlatformViewCreatedListener(params.onPlatformViewCreated)

diff --git a/dev/bots/analyze_sample_code.dart b/dev/bots/analyze_sample_code.dart
@@ -30,14 +30,12 @@ Future<void> main(List<String> arguments) async {
   final ArgParser argParser = ArgParser();
   argParser.addOption(
     'temp',
-    defaultsTo: null,
     help: 'A location where temporary files may be written. Defaults to a '
           'directory in the system temp folder. If specified, will not be '
           'automatically removed at the end of execution.',
   );
   argParser.addFlag(
     'verbose',
-    defaultsTo: false,
     negatable: false,
     help: 'Print verbose output for the analysis process.',
   );
@@ -52,12 +50,10 @@ Future<void> main(List<String> arguments) async {
   argParser.addFlag(
     'include-dart-ui',
     defaultsTo: true,
-    negatable: true,
     help: 'Includes the dart:ui code supplied by the engine in the analysis.',
   );
   argParser.addFlag(
     'help',
-    defaultsTo: false,
     negatable: false,
     help: 'Print help for this command.',
   );
@@ -69,7 +65,6 @@ Future<void> main(List<String> arguments) async {
   argParser.addFlag(
     'global-activate-snippets',
     defaultsTo: true,
-    negatable: true,
     help: 'Whether or not to "pub global activate" the snippets package. If set, will '
           'activate version $_snippetsActivateVersion',
   );
@@ -476,7 +471,6 @@ class SampleChecker {
         if (!Platform.environment.containsKey('FLUTTER_ROOT')) 'FLUTTER_ROOT': _flutterRoot,
         if (_flutterVersion!.isNotEmpty) 'FLUTTER_VERSION': _flutterVersion!,
       },
-      includeParentEnvironment: true,
     );
   }
 
@@ -1155,7 +1149,7 @@ class Sample {
     final StringBuffer buf = StringBuffer('sample ${args.join(' ')}\n');
     int count = start.line;
     for (final String line in input) {
-      buf.writeln(' ${count.toString().padLeft(4, ' ')}: $line');
+      buf.writeln(' ${count.toString().padLeft(4)}: $line');
       count++;
     }
     return buf.toString();

diff --git a/dev/bots/browser.dart b/dev/bots/browser.dart
@@ -94,8 +94,6 @@ class AppServer {
       debugPort: browserDebugPort,
       url: appUrl,
       userDataDirectory: userDataDirectory.path,
-      windowHeight: 1024,
-      windowWidth: 1024,
     ), onError: chromeErrorCompleter.complete);
     return AppServer._(server, chrome, chromeErrorCompleter.future);
   }

diff --git a/dev/bots/prepare_package.dart b/dev/bots/prepare_package.dart
@@ -687,7 +687,6 @@ class ArchivePublisher {
     try {
       await _runGsUtil(
         <String>['stat', cloudPath],
-        failOk: false,
       );
     } on PreparePackageException {
       // `gsutil stat gs://path/to/file` will exit with 1 if file does not exist
@@ -737,53 +736,45 @@ Future<void> main(List<String> rawArguments) async {
   final ArgParser argParser = ArgParser();
   argParser.addOption(
     'temp_dir',
-    defaultsTo: null,
     help: 'A location where temporary files may be written. Defaults to a '
         'directory in the system temp folder. Will write a few GiB of data, '
         'so it should have sufficient free space. If a temp_dir is not '
         'specified, then the default temp_dir will be created, used, and '
         'removed automatically.',
   );
   argParser.addOption('revision',
-      defaultsTo: null,
       help: 'The Flutter git repo revision to build the '
           'archive with. Must be the full 40-character hash. Required.');
   argParser.addOption(
     'branch',
-    defaultsTo: null,
     allowed: Branch.values.map<String>((Branch branch) => getBranchName(branch)),
     help: 'The Flutter branch to build the archive with. Required.',
   );
   argParser.addOption(
     'output',
-    defaultsTo: null,
     help: 'The path to the directory where the output archive should be '
         'written. If --output is not specified, the archive will be written to '
         "the current directory. If the output directory doesn't exist, it, and "
         'the path to it, will be created.',
   );
   argParser.addFlag(
     'publish',
-    defaultsTo: false,
     help: 'If set, will publish the archive to Google Cloud Storage upon '
         'successful creation of the archive. Will publish under this '
         'directory: $baseUrl$releaseFolder',
   );
   argParser.addFlag(
     'force',
     abbr: 'f',
-    defaultsTo: false,
     help: 'Overwrite a previously uploaded package.',
   );
   argParser.addFlag(
     'dry_run',
-    defaultsTo: false,
     negatable: false,
     help: 'Prints gsutil commands instead of executing them.',
   );
   argParser.addFlag(
     'help',
-    defaultsTo: false,
     negatable: false,
     help: 'Print help for this command.',
   );

diff --git a/dev/bots/test.dart b/dev/bots/test.dart
@@ -645,7 +645,7 @@ Future<void> _runFrameworkTests() async {
 
   Future<void> runLibraries() async {
     final List<String> tests = Directory(path.join(flutterRoot, 'packages', 'flutter', 'test'))
-      .listSync(followLinks: false, recursive: false)
+      .listSync(followLinks: false)
       .whereType<Directory>()
       .where((Directory dir) => dir.path.endsWith('widgets') == false)
       .map<String>((Directory dir) => path.join('test', path.basename(dir.path)) + path.separator)
@@ -1215,7 +1215,7 @@ Future<void> _ensureChromeDriverIsRunning() async {
   final Uri chromeDriverUrl = Uri.parse('http://localhost:4444/status');
   final HttpClientRequest request = await client.getUrl(chromeDriverUrl);
   final HttpClientResponse response = await request.close();
-  final Map<String, dynamic> webDriverStatus = json.decode(await response.transform(utf8.decoder).join('')) as Map<String, dynamic>;
+  final Map<String, dynamic> webDriverStatus = json.decode(await response.transform(utf8.decoder).join()) as Map<String, dynamic>;
   client.close();
   final bool webDriverReady = (webDriverStatus['value'] as Map<String, dynamic>)['ready'] as bool;
   if (!webDriverReady) {

diff --git a/dev/bots/test/analyze_test.dart b/dev/bots/test/analyze_test.dart
@@ -193,6 +193,6 @@ void main() {
         const Hash256(0xA8100AE6AA1940D0, 0xB663BB31CD466142, 0xEBBDBD5187131B92, 0xD93818987832EB89), // sha256("\xff")
         const Hash256(0x155644D3F13D98BF, 0, 0, 0),
       },
-    ), exitCode: 0);
+    ));
   });
 }
diff --git a/dev/bots/test/prepare_package_test.dart b/dev/bots/test/prepare_package_test.dart
@@ -266,7 +266,6 @@ void main() {
           tempDir,
           testRef,
           Branch.dev,
-          strict: true,
           processManager: processManager,
           subprocessOutput: false,
           platform: platform,
@@ -495,7 +494,7 @@ void main() {
           '$gsutilCall -- stat $gsArchivePath': <ProcessResult>[ProcessResult(0, 0, '', '')],
         };
         processManager.addCommands(convertResults(calls));
-        expect(() async => publisher.publishArchive(false), throwsException);
+        expect(() async => publisher.publishArchive(), throwsException);
       });
 
       test('publishArchive does not throw if forceUpload is true and artifact already exists on cloud storage', () async {

diff --git a/dev/bots/unpublish_package.dart b/dev/bots/unpublish_package.dart
@@ -401,7 +401,6 @@ Future<void> main(List<String> rawArguments) async {
   final ArgParser argParser = ArgParser();
   argParser.addOption(
     'temp_dir',
-    defaultsTo: null,
     help: 'A location where temporary files may be written. Defaults to a '
         'directory in the system temp folder. If a temp_dir is not '
         'specified, then by default a generated temporary directory will be '
@@ -431,7 +430,6 @@ Future<void> main(List<String> rawArguments) async {
   );
   argParser.addFlag(
     'confirm',
-    defaultsTo: false,
     help: 'If set, will actually remove the archive from Google Cloud Storage '
         'upon successful execution of this script. Published archives will be '
         'removed from this directory: $baseUrl$releaseFolder.  This option '
@@ -440,7 +438,6 @@ Future<void> main(List<String> rawArguments) async {
   );
   argParser.addFlag(
     'help',
-    defaultsTo: false,
     negatable: false,
     help: 'Print help for this command.',
   );

diff --git a/dev/conductor/core/lib/src/repository.dart b/dev/conductor/core/lib/src/repository.dart
@@ -496,7 +496,6 @@ class FrameworkRepository extends Repository {
         name: RemoteName.upstream,
         url: 'file://$upstreamPath/',
       ),
-      localUpstream: false,
       previousCheckoutLocation: previousCheckoutLocation,
     );
   }

diff --git a/dev/conductor/core/lib/src/roll_dev.dart b/dev/conductor/core/lib/src/roll_dev.dart
@@ -43,7 +43,6 @@ class RollDevCommand extends Command<void> {
       kCandidateBranch,
       help: 'Specifies which git branch to roll to the dev branch. Required.',
       valueHelp: 'branch',
-      defaultsTo: null, // This option is required
     );
     argParser.addFlag(
       kForce,