[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predictive back MaterialSharedAxis sample #156

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Predictive back MaterialSharedAxis sample #156

merged 7 commits into from
Mar 26, 2024

Conversation

trambui09
Copy link
Contributor

Add MaterialSharedAxis transition to sample.
Video

ashnohe
ashnohe requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor
@ashnohe ashnohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Tram. Can you add in a few more things:

  1. Update to material = "1.12.0-beta01" in libs.versions.toml
  2. Add an explanation of this sample in samples/user-interface/predictiveback/README.md.
  3. Add the related animation in PBListFragment.kt in onCreateView
enterTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ true)
returnTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ false)
  1. Move the enterTransition and returnTransition to onCreateView in PBMaterialSharedAxisAnimations.kt. You can likely delete all of onViewCreated within this file.

samples/user-interface/predictiveback/.idea/migrations.xml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file from the commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

samples/user-interface/predictiveback/.idea/misc.xml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file from the commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

samples/user-interface/predictiveback/.idea/vcs.xml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file from the commit

samples/user-interface/predictiveback/.idea/workspace.xml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file from the commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...eback/src/main/java/com/example/platform/ui/predictiveback/PBMaterialSharedAxisAnimations.kt Outdated
import android.view.ViewGroup
import androidx.activity.OnBackPressedCallback
import androidx.fragment.app.Fragment
import androidx.navigation.fragment.FragmentNavigatorExtras
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this import as it is unused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...eback/src/main/java/com/example/platform/ui/predictiveback/PBMaterialSharedAxisAnimations.kt Outdated
enterTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ true)
returnTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ false)

val predictiveBackCallback = object : OnBackPressedCallback(true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the callback, a callback is not needed to run cross-fragment animations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

yaraki
yaraki reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor
@yaraki yaraki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except what Ash pointed out

trambui09
trambui09 commented Mar 26, 2024
View reviewed changes
Copy link
Contributor Author
@trambui09 trambui09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ash! Applied the edits and had a small follow up question!

...erface/predictiveback/src/main/java/com/example/platform/ui/predictiveback/PBListFragment.kt
exitTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ true)
reenterTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ false)


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashnohe, was wondering if it should be enter and return OR exit and reenter Transitions? the docs has exit and reenter as the transitions for FragmentA and enter and return transitions for fragmentB?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PBListFragment is Fragment A so exit and reenter are correct.

...eback/src/main/java/com/example/platform/ui/predictiveback/PBMaterialSharedAxisAnimations.kt Outdated
enterTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ true)
returnTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ false)

val predictiveBackCallback = object : OnBackPressedCallback(true) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...eback/src/main/java/com/example/platform/ui/predictiveback/PBMaterialSharedAxisAnimations.kt Outdated
import android.view.ViewGroup
import androidx.activity.OnBackPressedCallback
import androidx.fragment.app.Fragment
import androidx.navigation.fragment.FragmentNavigatorExtras
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

samples/user-interface/predictiveback/.idea/workspace.xml Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

samples/user-interface/predictiveback/.idea/misc.xml Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

samples/user-interface/predictiveback/.idea/migrations.xml Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ashnohe
ashnohe approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor
@ashnohe ashnohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM. Thanks!

samples/user-interface/predictiveback/README.md Outdated
## Cross-fragment animation with MaterialSharedAxis

MaterialSharedAxis is a Visibility transition. A Visibility transition is triggered when the target
View's visibility is changed or when the View is added or removed. This means MaterialSharedAxis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say fragments instead of views, since this is a cross-fragment transition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! TY!

...erface/predictiveback/src/main/java/com/example/platform/ui/predictiveback/PBListFragment.kt
exitTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ true)
reenterTransition = MaterialSharedAxis(MaterialSharedAxis.Z, /* forward= */ false)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PBListFragment is Fragment A so exit and reenter are correct.

@trambui09 trambui09 merged commit f4e1982 into android:main Mar 26, 2024
4 checks passed
@trambui09 trambui09 deleted the material-shared-axis branch March 27, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaraki yaraki yaraki left review comments

@ashnohe ashnohe ashnohe approved these changes

@alabiaga alabiaga Awaiting requested review from alabiaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trambui09 @yaraki @ashnohe