[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DV profile 10 handling in getAlternativeCodecMimeType() method #1389

Merged

Conversation

ybai001
Copy link
Contributor
@ybai001 ybai001 commented May 23, 2024

I found your team had added DV profile 10 support in https://github.com/androidx/media/blob/main/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/mediacodec/MediaCodecUtil.java#L1346 in latest main branch. But it seems that method getAlternativeCodecMimeType() should be updated too. So I submitted this contribution.

@microkatz
Copy link
Contributor

Hi @ybai001

Would it be possible to open a new PR from an individual-owned fork? We can't push changes to organization-owned forks like this one unless we have collaborator access. If that's not possible then we can still merge this PR but it will result in an 'evil' merge. See more info here: https://github.com/androidx/media/blob/release/CONTRIBUTING.md#push-access-to-pr-branches

@ybai001
Copy link
Contributor Author
ybai001 commented May 24, 2024

Hi @ybai001

Would it be possible to open a new PR from an individual-owned fork? We can't push changes to organization-owned forks like this one unless we have collaborator access. If that's not possible then we can still merge this PR but it will result in an 'evil' merge. See more info here: https://github.com/androidx/media/blob/release/CONTRIBUTING.md#push-access-to-pr-branches

Hi, @microkatz , Yes, I was told about it in another pull request. Unfortunately, due to the company process limitation, I can't do it now. So please handle it as an evil merge. At the same time, we are trying to solve this situation in our company internally so that we can do it as you said in future. But it can't be done in short time.

@copybara-service copybara-service bot merged commit 67b799c into androidx:main May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants