[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Make deep link path arguments to not include slash #153

Conversation

osipxd
Copy link
Contributor
@osipxd osipxd commented Apr 3, 2021

Proposed Changes

Slash is used for URI path splitting. Arguments should not include more than one path section.
I purpose to replace (.+?) with ([^/]+?) in resulting regexp.

Testing

Added corresponing tests to NavDestinationAndroidTest

Test: ./gradlew test connectedCheck

Issues Fixed

Fixes: b/184072811

Slash is used for URI path splitting. Arguments should not include more than one path section.

Test: ./gradlew test connectedCheck
Fixes: b/184072811
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link
google-cla bot commented Apr 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@osipxd osipxd changed the title Make deep link path arguments to not include slash [Navigation] Make deep link path arguments to not include slash Apr 3, 2021
@osipxd
Copy link
Contributor Author
osipxd commented Apr 3, 2021

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link
google-cla bot commented Apr 3, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@osipxd osipxd deleted the bugfix/184072811-deep-link-argument-slash branch April 15, 2021 19:21
@geak
Copy link
geak commented Feb 2, 2022

This breaks cases when argument needs to have a slash in it:

scheme://foo/{page}

page = bar/xyz

So DL scheme://foo/bar/xyz doesn't work 😢

@ianhanniballake
Copy link
Member

If you want special characters included as part of an argument, you should be encoding them via Uri.encode. Navigation will automatically decode them for you as part of its parsing.

@525411
Copy link
525411 commented Feb 3, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants