[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce early exit path for unlikely to be a resource path case. #669

Closed
wants to merge 1 commit into from
Closed

Introduce early exit path for unlikely to be a resource path case. #669

wants to merge 1 commit into from

Conversation

nodmp
Copy link
Contributor
@nodmp nodmp commented Feb 28, 2024

Proposed Changes

This CL does some improvements:

  • Introduce the early exit path if the given string is not likely the path in resource file. Prevents insertion of a large number of empty messages into the main thread

Testing

Test: ./gradlew test connectedCheck

Issues Fixed

Fixes: The bug on https://issuetracker.google.com/issues/323403933 being fixed

@nodmp
Introduce early exit path for unlikely to be a resource path case.
ac4ece3 
This CL does some improvements:
- Introduce the early exit path if the given string is not likely the
path in resource file. Prevents insertion of a large number of empty messages into the main thread

Test: ./gradlew test connectedCheck
Fixes: b/323403933
@dlam dlam requested review from alanv and removed request for yigit and dlam February 28, 2024 19:22
@dlam
Copy link
Member
dlam commented Feb 28, 2024

I am not the main reviewer on appcompat, but my guess is it would be hard to accept this PR because it is not solving the root cause of the problem. Aside from that, we also require a test with every bug fix code change, which in this case would need to clearly show the failing case from the bug being solved by this change.

@dlam dlam closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanv alanv Awaiting requested review from alanv alanv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nodmp @dlam