[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make remember() and LaunchedEffect() receive its key parameters as receivers #682

Closed
wants to merge 0 commits into from
Closed

Make remember() and LaunchedEffect() receive its key parameters as receivers #682

wants to merge 0 commits into from

Conversation

JunJaBoy
Copy link
Contributor
@JunJaBoy JunJaBoy commented May 13, 2024 •
edited
Loading

Proposed Changes

  • Made remember() receives its key parameters as receivers
  • Made LaunchedEffect() receives its key parameters as receivers
  • Made DisposableEffect() receives its key parameters as receivers

Testing

Test: None

Issues Fixed

Fixes: The issue on https://issuetracker.google.com/issues/340041661 being fixed

@Miha-x64
Copy link

Hi! Just hanging around the repo with some unwanted advice:

  • Any? is useless, you need <T1, T2, …> etc
  • .toList() is ain't free. .asList() is cheaper; Array<out Any?> is free but Any? elements are still useless

@JunJaBoy JunJaBoy closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimgoog jimgoog Awaiting requested review from jimgoog

@lelandrichardson lelandrichardson Awaiting requested review from lelandrichardson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JunJaBoy @Miha-x64