[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove kona-derive-alloy #789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Remove kona-derive-alloy #789

wants to merge 1 commit into from
+796 −1,793

Conversation

refcell
Copy link
Collaborator
@refcell refcell commented Nov 6, 2024

Description

Removes kona-derive-alloy and inlines the blob provider in the kona-host.

Future work should be done to simplify the blob + beacon provider now in the kona-host.

@refcell refcell requested a review from clabby as a code owner November 6, 2024 23:47
@refcell refcell added A-derive-alloy Area: kona-derive-alloy crate A-host Area: host binary labels Nov 6, 2024
@refcell
Copy link
Collaborator Author
refcell commented Nov 6, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell added the K-chore Kind: chore label Nov 6, 2024
@refcell refcell self-assigned this Nov 6, 2024
@codecov Codecov
Copy link
codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.7%. Comparing base (534b32e) to head (cd0a8d6).

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell marked this pull request as draft November 7, 2024 01:46
@refcell refcell marked this pull request as ready for review November 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby Awaiting requested review from clabby clabby is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@refcell refcell

Labels
A-derive-alloy Area: kona-derive-alloy crate A-host Area: host binary K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@refcell