[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade luarocks to 3.8.0 which converts git:// to https:// #5825

Merged
merged 1 commit into from
Dec 18, 2021
Merged

feat: upgrade luarocks to 3.8.0 which converts git:// to https:// #5825

merged 1 commit into from
Dec 18, 2021

Conversation

spacewander
Copy link
Member

The Luarocks 2.x is already broken.
Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
feat: upgrade luarocks to 3.8.0 which converts git:// to https://
cbaa26b 
The Luarocks 2.x is already broken.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review December 16, 2021 03:22
@juzhiyuan juzhiyuan requested review from tokers and tao12345666333 and removed request for tokers December 16, 2021 07:54
@tao12345666333 tao12345666333 removed their request for review December 16, 2021 08:33
@tao12345666333
Copy link
Member

I am not familiar with the operating mechanism of luarocks. 😮‍💨 Is there any explanation or release note for this change?

@spacewander
Copy link
Member Author

Luarocks automatically handles the URL conversion in this commit: luarocks/luarocks@9ff512e, which is included in v3.8.0. So there is no need to handle this by ourselves.

@tokers
Copy link
Contributor
tokers commented Dec 16, 2021

Not sure whether this is good for the user experience as it adds more constraints for the version of luarocks.

@spacewander
Copy link
Member Author

No, as I mentioned in the commit message. The luarocks 2.x is actually broken. We just make sure people won't be trapped in it.

@spacewander
Copy link
Member Author
spacewander commented Dec 17, 2021 •
edited
Loading

The luarocks 2.x has been broken for a time. This PR just admitted it.
In fact, it doesn't handle the new rockspec format and the dependency management which have been reported by the user.
That is why the issue template requires people to submit their luarocks version.

@tokers
Copy link
Contributor
tokers commented Dec 17, 2021

No, as I mentioned in the commit message. The luarocks 2.x is actually broken. We just make sure people won't be trapped in it.

Sorry, I misunderstood the meaning of this PR, I thought we add some constraints for the LuaRocks 3.x.

@membphis membphis merged commit 5cde5ae into apache:master Dec 18, 2021
@leslie-tsang leslie-tsang mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@tokers tokers tokers approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spacewander @tao12345666333 @tokers @membphis @leslie-tsang