[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DNS): allow specifying port to override the discovered one #6764

Merged
merged 1 commit into from
Apr 1, 2022
Merged

feat(DNS): allow specifying port to override the discovered one #6764

merged 1 commit into from
Apr 1, 2022

Conversation

spacewander
Copy link
Member

It makes the workaround in #6732 (comment)
work.
Signed-off-by: spacewander spacewanderlzx@gmail.com

Description

Fixes #6732

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander
feat(DNS): allow specifying port to override the discovered one
adcbf0b 
It makes the workaround in apache#6732 (comment)
work.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander
Copy link
Member Author

It also make the DNS discovery work more like the upstream domain.

@spacewander spacewander marked this pull request as ready for review March 31, 2022 08:46
@spacewander spacewander merged commit ecfd3ff into apache:master Apr 1, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@spacewander @Liu-Junlin
feat(DNS): allow specifying port to override the discovered one (apac…
be80f78 
…he#6764)

It makes the workaround in apache#6732 (comment)
work.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit that referenced this pull request Jun 30, 2022
@spacewander
feat(DNS): allow specifying port to override the discovered one (#6764)
aa27460 
It makes the workaround in #6732 (comment)
work.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: dns service discovery upstreams are not working in GKE
3 participants
@spacewander @tzssangglass @leslie-tsang