[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the message clearer when API key is missing #11370

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

pottekkat
Copy link
Contributor
@pottekkat pottekkat commented Jun 25, 2024

Description

When the key is missing while accessing a route with the key-auth plugin enabled, we get the message, "Missing API key found in request," which isn't correct. How is something missing in the request, found in the request?

Instead, it should be phrased as "Missing API key in request," which is clearer.

While users may be able to make sense of the older message, it is an easy enough change.

This PR updates the message in the code, tests, and docs.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@pottekkat pottekkat merged commit 6d2de7e into apache:master Jun 26, 2024
52 checks passed
@pottekkat pottekkat deleted the fix/inline-doc/key-auth/1 branch June 26, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants