[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose GroupIntoBatches parameters for WriteFiles auto-sharding transform #31617

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Expose GroupIntoBatches parameters for WriteFiles auto-sharding transform #31617

merged 1 commit into from
Jun 25, 2024

Conversation

Amar3tto
Copy link
Contributor
@Amar3tto Amar3tto commented Jun 17, 2024 •
edited
Loading

Fixes #30131

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Jun 17, 2024
@Amar3tto Amar3tto force-pushed the write-files-batch-parameters branch from 1a074d8 to ca993e7 Compare June 17, 2024 14:02
@Amar3tto Amar3tto marked this pull request as ready for review June 17, 2024 14:51
@Amar3tto
Copy link
Contributor Author

R: @Abacn

@github-actions GitHub Actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Abacn
Abacn reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor
@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the feature request, this exposes the configs in WriteFiles, however end user most likely use file-based IOs (not WriteFiles directly), e.g. TextIO and other IOs, this is still not exposed.

I suggest at least we implement this to TextIO, so this PR is useful for end user, and other file based IOs could be follow up.

@Amar3tto Amar3tto force-pushed the write-files-batch-parameters branch from 57f6342 to 6355e3a Compare June 21, 2024 11:21
@Amar3tto
Copy link
Contributor Author

Regarding the feature request, this exposes the configs in WriteFiles, however end user most likely use file-based IOs (not WriteFiles directly), e.g. TextIO and other IOs, this is still not exposed.

I suggest at least we implement this to TextIO, so this PR is useful for end user, and other file based IOs could be follow up.

Implemented for TextIO

@Amar3tto
Copy link
Contributor Author

Run Java_GCP_IO_Direct PreCommit

@Amar3tto Amar3tto requested a review from Abacn June 21, 2024 12:42
@Amar3tto
Copy link
Contributor Author

Run Java PreCommit

@Abacn Abacn merged commit 1037ede into apache:master Jun 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abacn Abacn Abacn approved these changes

Assignees
No one assigned
Labels
java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Expose GroupIntoBatches Parameters for WriteFiles Autosharding transform
2 participants
@Amar3tto @Abacn