[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: update vm haenable only for supported vms #5847

Merged
merged 1 commit into from
Jan 11, 2022
Merged

ui: update vm haenable only for supported vms #5847

merged 1 commit into from
Jan 11, 2022

Conversation

shwstppr
Copy link
Contributor
@shwstppr shwstppr commented Jan 11, 2022 •
edited
Loading

Description

Fixes #5743

For VMs which have service offering that does not allow HA, haenable option will be not shown in the UpdateVM UI form.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

VM with offering that doesn't offer HA
Screenshot from 2022-01-11 12-55-14

VM with offering that offer HA
Screenshot from 2022-01-11 12-55-55

How Has This Been Tested?

@shwstppr
ui: update vm haenable only for supported vms
e049889 
Fixes apache#5743

For VMs which have service offering that does not allow HA, haenable option will be not shown in the UpdateVM UI form.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr self-assigned this Jan 11, 2022
@shwstppr shwstppr linked an issue Jan 11, 2022 that may be closed by this pull request
Exception while update vm with 'HA Enabled' checked #5743
Closed
@utchoang
Copy link

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

utchoang
utchoang approved these changes Jan 11, 2022
View reviewed changes
Copy link
@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5847 (SL-JID-1000)

weizhouapache
weizhouapache approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member
@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sureshanaparti
Copy link
Contributor

Verified 'Edit instance' UI form with HA and non-HA compute offering for a stopped VM. LGTM.

@sureshanaparti sureshanaparti merged commit c08592c into apache:4.16 Jan 11, 2022
@sureshanaparti sureshanaparti mentioned this pull request Jan 11, 2022
Closed
@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache weizhouapache approved these changes

@utchoang utchoang utchoang approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@GabrielBrascher GabrielBrascher Awaiting requested review from GabrielBrascher

@GutoVeronezi GutoVeronezi Awaiting requested review from GutoVeronezi

Assignees

@shwstppr shwstppr

Labels
None yet
Projects
No open projects
Apache CloudStack 4.16.1
Status: Done
Milestone
4.16.1.0
Development

Successfully merging this pull request may close these issues.

Exception while update vm with 'HA Enabled' checked
5 participants
@shwstppr @utchoang @blueorangutan @sureshanaparti @weizhouapache