[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: fix getDiagnosticsData files field #5853

Merged
merged 1 commit into from
Jan 12, 2022
Merged

ui: fix getDiagnosticsData files field #5853

merged 1 commit into from
Jan 12, 2022

Conversation

shwstppr
Copy link
Contributor

Description

Fixes #5707

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

getdiagnosticsdata

How Has This Been Tested?

@shwstppr
ui: fix getDiagnosticsData files field
ec14326 
Fixes apache#5707

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5853 (SL-JID-1005)

utchoang
utchoang approved these changes Jan 12, 2022
View reviewed changes
Copy link
@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sureshanaparti sureshanaparti linked an issue Jan 12, 2022 that may be closed by this pull request
Can't paste any value in Get Diagnostics Data #5707
Closed
@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Jan 12, 2022
sureshanaparti
sureshanaparti approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor
@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sureshanaparti
Copy link
Contributor

Verified the fix. Minor UI change, smoke tests not needed.

@sureshanaparti sureshanaparti merged commit c17ae74 into apache:4.16 Jan 12, 2022
@sureshanaparti sureshanaparti mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utchoang utchoang utchoang approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

@shwstppr shwstppr

Labels
component:UI
Projects
No open projects
Apache CloudStack 4.16.1
Status: Done
Milestone
4.16.1.0
Development

Successfully merging this pull request may close these issues.

Can't paste any value in Get Diagnostics Data
4 participants
@shwstppr @blueorangutan @sureshanaparti @utchoang