UI: Fix new UI missing 4 parameters when adding a BareMetal host #5812
Conversation
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Hi @utchoang, Is this good to go in 4.16.1? If so, please rebase with 4.16. Thanks. |
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
There was a problem hiding this comment.
Thanks for the quick changes @utchoang .
I've tried adding the host with dummy values, but it failed with a NPE error. On the further check, it is found that hosttag is a mandatory field in case of baremetal
Can you please make hosttag as mandatory field in UI in case of baremetal and also add a null check at ResourceManagerImpl.java#L731 to fix the API flow.
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Hi @utchoang Can you resolve the conflicts in this PR branch. Thanks. |
# Conflicts: # ui/src/views/infra/HostAdd.vue
1 similar comment
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Hi @utchoang noticed error message: "Username and Password need to be provided." after submitting the details (including username and password) in 'Add Host' form. Please check. |
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Verified the missing parameters (CPU cores, CPU MHz, Memory, Host Mac) in 'Add Host' UI form for BareMetal host, and the API fired from the UI with dummy values. |
Description
This PR fixes #5772
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?