[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in datafusion-examples/datafusion-cli/docs #11259

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

lewiszlw
Copy link
Member
@lewiszlw lewiszlw commented Jul 4, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Many OSS projects use this check in their ci workflows, I think it's nice to have it in datafusion workflows.

This pr only contains check for datafusion-cli, datafusion-examples and docs.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor
@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw

The code change with typos fixed is great. However, unfortunately I don't think we can use the non-github action in our CI runs 😢

.github/workflows/rust.yml Outdated Show resolved Hide resolved
@alamb alamb marked this pull request as draft July 6, 2024 11:52
@lewiszlw lewiszlw changed the title Add typos check in ci workflow Fix typos in datafusion-examples/datafusion-cli/docs Jul 8, 2024
@lewiszlw lewiszlw marked this pull request as ready for review July 8, 2024 03:20
Copy link
Contributor
@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw

@alamb alamb merged commit 2f02c43 into apache:main Jul 8, 2024
25 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* Add typos check in ci workflow

* typos.toml

* exclude more

* typos autofix

* remove typos ci
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 18, 2024
* Add typos check in ci workflow

* typos.toml

* exclude more

* typos autofix

* remove typos ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants