-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serialization/deserialization for custom physical exprs in proto #11387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lewiszlw -- this makes sense to me
cc @thinkharderdev and @joroKr21 as I think this may also relate to your usecase
.downcast_ref::<CustomPredicateExpr>() | ||
.is_some() | ||
{ | ||
buf.extend_from_slice("CustomPredicateExpr".as_bytes()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Thanks again @lewiszlw |
…oto (apache#11387) * Add PhysicalExtensionExprNode * regen proto * Add ser/de extension expr logic * Add test and fix clippy lint
…oto (apache#11387) * Add PhysicalExtensionExprNode * regen proto * Add ser/de extension expr logic * Add test and fix clippy lint
…oto (apache#11387) * Add PhysicalExtensionExprNode * regen proto * Add ser/de extension expr logic * Add test and fix clippy lint
Which issue does this PR close?
Closes #11350.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?