[Android] fix scroller memory leack because of OnAttachedListener (#1774

)
apache · Nov 22, 2018 · 4e27e0d · 4e27e0d
1 parent caff581
commit 4e27e0d
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java
@@ -100,6 +100,7 @@ public class WXScroller extends WXVContainer<ViewGroup> implements WXScrollViewL
   private int pageSize = 0;
   private boolean pageEnable = false;
   private boolean mIsHostAttachedToWindow = false;
+  private View.OnAttachStateChangeListener mOnAttachStateChangeListener;
 
   public static class Creator implements ComponentCreator {
     @Override
@@ -376,6 +377,9 @@ public void destroy() {
     if (mStickyMap != null) {
       mStickyMap.clear();
     }
+    if (mOnAttachStateChangeListener != null && getInnerView() != null) {
+      getInnerView().removeOnAttachStateChangeListener(mOnAttachStateChangeListener);
+    }
     if (getInnerView() != null && getInnerView() instanceof IWXScroller) {
       ((IWXScroller) getInnerView()).destroy();
     }
@@ -608,7 +612,7 @@ public void onGlobalLayout() {
         }
       }
     });
-    host.addOnAttachStateChangeListener(new View.OnAttachStateChangeListener() {
+    mOnAttachStateChangeListener = new View.OnAttachStateChangeListener() {
       @Override
       public void onViewAttachedToWindow(View v) {
         mIsHostAttachedToWindow = true;
@@ -620,7 +624,8 @@ public void onViewDetachedFromWindow(View v) {
         mIsHostAttachedToWindow = false;
         dispatchDisappearEvent();
       }
-    });
+    };
+    host.addOnAttachStateChangeListener(mOnAttachStateChangeListener);
     return host;
   }