[Android] feature : check bundle_type and report error (#2424)

apache · May 9, 2019 · b5dd77c · b5dd77c
1 parent 0ce90fb
commit b5dd77c
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 0 deletions.
diff --git a/android/sdk/src/main/java/com/taobao/weex/WXHttpListener.java b/android/sdk/src/main/java/com/taobao/weex/WXHttpListener.java
@@ -89,6 +89,10 @@ public void setSDKInstance(WXSDKInstance instance) {
         this.instance = instance;
     }
 
+    protected WXSDKInstance getInstance() {
+        return instance;
+    }
+
     @Override
     public void onHttpStart() {
         if (this.instance != null

diff --git a/android/sdk/src/main/java/com/taobao/weex/bridge/RequestHandler.java b/android/sdk/src/main/java/com/taobao/weex/bridge/RequestHandler.java
@@ -31,9 +31,12 @@
 import com.taobao.weex.adapter.URIAdapter;
 import com.taobao.weex.base.CalledByNative;
 import com.taobao.weex.bridge.WXBridgeManager.BundType;
+import com.taobao.weex.common.WXErrorCode;
 import com.taobao.weex.common.WXRequest;
 import com.taobao.weex.common.WXResponse;
 import com.taobao.weex.http.WXHttpUtil;
+import com.taobao.weex.utils.WXExceptionUtils;
+
 import java.util.HashMap;
 
 public class RequestHandler {
@@ -91,6 +94,15 @@ public void onSuccess(WXResponse response) {
         String script = new String(response.originalData);
         BundType bundleType = WXBridgeManager.getInstance().getBundleType("", script);
         String bundleTypeStr = bundleType == null ? "Others" : bundleType.toString();
+        if ("Others".equalsIgnoreCase(bundleTypeStr) && null != getInstance()){
+          WXExceptionUtils.commitCriticalExceptionRT(
+              getInstance().getInstanceId(),
+              WXErrorCode.WX_KEY_EXCEPTION_NO_BUNDLE_TYPE,
+              "RequestHandler.onSuccess",
+              "eagle ->" +WXErrorCode.WX_KEY_EXCEPTION_NO_BUNDLE_TYPE.getErrorMsg(),
+              null
+          );
+        }
         nativeInvokeOnSuccess(sNativeCallback, script, bundleTypeStr);
     }
 

diff --git a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -1618,6 +1618,15 @@ private void invokeCreateInstance(@NonNull WXSDKInstance instance, Script templa
           }
           return;
         } else {
+          //bad case for js bundle with out bundletype header //vue or rax
+          WXExceptionUtils.commitCriticalExceptionRT(
+                instance.getInstanceId(),
+                WXErrorCode.WX_KEY_EXCEPTION_NO_BUNDLE_TYPE,
+                "invokeCreateInstance",
+                WXErrorCode.WX_KEY_EXCEPTION_NO_BUNDLE_TYPE.getErrorMsg(),
+                null
+          );
+
           invokeExecJS(instance.getInstanceId(), null, METHOD_CREATE_INSTANCE, args, false);
           return;
         }

diff --git a/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java b/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
@@ -222,6 +222,7 @@ public enum WXErrorCode {
   WX_RENDER_ERR_TEXTURE_SETBACKGROUND("-9620", "WX_RENDER_ERR_TEXTURE_SETBACKGROUND", ErrorType.NATIVE_ERROR, ErrorGroup.NATIVE),
 
 
+  WX_KEY_EXCEPTION_NO_BUNDLE_TYPE("-9801", "Fatal Error : No bundle type in js bundle head, cause white screen or memory leak!!", ErrorType.JS_ERROR, ErrorGroup.JS),
   /**
    * degrade code.
    */