This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-650][Android] fix appear & disappear problem of items in scroller #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problem fixed in this situation.
When a scroller is shown by sliding up a list, appear events of the item in scroller can not be fired. This is caused by the scroller component in Android only fires appear / disappear event when scrolling exclude the time that scroller is attached / detached to window.
The logic that check a view is visible in scroller component is defective, because in the time of call check method, the view may not in screen but it will show after this tick.