[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] Fix crash if observer is removed twice. Change some variables t… #1665

Merged
merged 1 commit into from
Oct 24, 2018
Merged

[iOS] Fix crash if observer is removed twice. Change some variables t… #1665

merged 1 commit into from
Oct 24, 2018

Conversation

wqyfavor
Copy link
Member

…o static.

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link
weex-bot commented Oct 24, 2018 •
edited
Loading
Warnings
⚠️ No Changelog changes!
Messages
📖 danger test finished.

Generated by 🚫 dangerJS

@cxfeng1-zz cxfeng1-zz merged commit 4351ca7 into apache:master Oct 24, 2018
@wqyfavor wqyfavor deleted the fix-duplicate-remove-observer branch November 23, 2018 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wqyfavor @weex-bot @cxfeng1-zz