[go: nahoru, domu]

Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Core] Let affine types of "scroller", "list", "waterfall" match Rend… #1723

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

wqyfavor
Copy link
Member
@wqyfavor wqyfavor commented Nov 7, 2018

…erList logic. Autodetect subclass when registering a component and register its affine type.

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

…erList logic. Autodetect subclass when registering a component and register its affine type.
@weex-bot
Copy link
weex-bot commented Nov 7, 2018
Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

Copy link
Contributor
@jianhan-he jianhan-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit f1117e5 into apache:master Nov 8, 2018
@wqyfavor wqyfavor deleted the fix-weexcore-renderlist branch November 23, 2018 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants